Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix capture exit code failed caused by set -e #26934

Merged
merged 1 commit into from
Sep 3, 2020
Merged

Fix capture exit code failed caused by set -e #26934

merged 1 commit into from
Sep 3, 2020

Conversation

Avin0323
Copy link
Contributor

@Avin0323 Avin0323 commented Sep 2, 2020

PR types

Others

PR changes

Others

Describe

set -e causes capture exit code failed, then add set +e in build_and_check. And change the exit code of check_style to 4.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Sep 2, 2020

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

luotao1
luotao1 approved these changes Sep 3, 2020
View reviewed changes
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 26c698e into PaddlePaddle:develop Sep 3, 2020
@Avin0323 Avin0323 deleted the fix-pr26846-missing-problem branch September 3, 2020 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luotao1 luotao1 luotao1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Avin0323 @luotao1