Fix bug in MultiGradientMachine. #2650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hedaoyuan
approved these changes
Jun 28, 2017
xinghai-sun
approved these changes
Jun 28, 2017
pkuyym
approved these changes
Jun 28, 2017
| void TrainerThread::backwardCallback(Parameter* para) { | ||
| // CPU parameters are merged in the end | ||
| if (!para->useGpu()) return; | ||
| if (!para->useGpu() || para->isStatic()) return; |
There was a problem hiding this comment.
Better to add detail comments here.
qingqing01
commented
Jun 28, 2017
| void TrainerThread::backwardCallback(Parameter* para) { | ||
| // CPU parameters are merged in the end | ||
| if (!para->useGpu()) return; | ||
| if (!para->useGpu() || para->isStatic()) return; |
There was a problem hiding this comment.
If the batch size for one thread is 0, all the parameters will call backwardCallback function to merge gradient in the line 593. But the static parameters which do not need to be updated should not call backwardCallback . So add a check here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2649