Make pserver able to get server index without etcd (decouple pserver with etcd) #2634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helinwang
force-pushed
the
decouple
branch
2 times, most recently
from
c8296be to
175015b
Compare
…with etcd) The pserver need to have server index for saving model on the distributed file system. The server index comes from etcd if etcd is used, or user can manually specify them. So we need pserver.NewService() to take index as an argument. Since index could come from etcd, it would be strange if pserver takes an index as argument, at the same time get the index from etcd. so we will need to decouple pserver with etcd.
dzhwinter
reviewed
Jun 28, 2017
|
|
||
| go func(l net.Listener) { | ||
| s, err := pserver.NewService("", time.Second*5) | ||
| s, err := pserver.NewService(0) |
There was a problem hiding this comment.
I can't catch up what 0 meaning here, pserver index?
There was a problem hiding this comment.
my bad, I found it in the bottom. maybe add some comment here is better
There was a problem hiding this comment.
Maybe if develop is confused, he can check the definition of pserver.NewService :) Please let me know if you think otherwise.
dzhwinter
reviewed
Jun 29, 2017
| return pserverIdx, nil | ||
| } | ||
|
|
||
| func (e *EtcdClient) initDesiredPsercers(ctx context.Context, numPservers int) (*clientv3.TxnResponse, error) { |
There was a problem hiding this comment.
there is a typo here
initDesiredPservers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pserver need to have server index for saving model on the
distributed file system. The server index comes from etcd if etcd is
used, or user can manually specify them. So we need
pserver.NewService() to take index as an argument. Since index could
come from etcd, it would be strange if pserver takes an index as
argument, at the same time get the index from etcd. so we will need to
decouple pserver with etcd.