Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【paddle.fleet】fleet_util move to paddle.fleet #25805

Merged
merged 27 commits into from
Aug 7, 2020
Merged

【paddle.fleet】fleet_util move to paddle.fleet #25805

merged 27 commits into from
Aug 7, 2020

Conversation

123malin
Copy link
Contributor

@123malin 123malin commented Jul 29, 2020 •
edited
Loading

PR types

New features

PR changes

APIs

Describe

  1. add paddle.fleet.role_maker, including rolemakerBase, PaddleCloudRoleMaker, UserDefinedRoleMaker
  2. add paddle.fleet.util_factory, including set_file_system, collective apis（barrier, all_reduce, all_gather)，and other debug tools(e.g. program_check, params_check...)

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@guru4elephant guru4elephant changed the title fleet_util move to paddle.fleet 【paddle.fleet】fleet_util move to paddle.fleet Aug 2, 2020
123malin and others added 23 commits August 3, 2020 16:31
@123malin
test=develop, add unittest
5c501b2
@123malin
Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…
03223c2 
… fleet_util
@123malin
test=develop, bug fix for setup
24030c6
@123malin
test=develop, bug fix
02d00f5
@123malin
test=develop, bug fix
5603baa
@WuHaobo
Merge remote-tracking branch 'upstream/develop' into develop
929ca5c
@WuHaobo
delete out in inverse
2e6fa20
@123malin
test=develop, bug fix
1d4051a
@123malin
test=develop, open test_dist_fleet_ctr
4759ca1
@123malin
test=develop, unittest
edceacb
@123malin
test=develop, bug fix
a0abc75
@123malin
test=develop, Merge remote-tracking branch 'WuHaobo/delete_inverse_ou…
dd7b70f 
…t' into fleet_util
@123malin
test=develop, add unittest
4d8e4dd
@123malin
test=develop, bug fix for unittest
987639e
@123malin
test=develop, bug fix for python35
8585529
@123malin
test=develop, bug fix
c8eaa2a
@123malin
test=develop,Merge branch 'develop' of https://github.com/PaddlePaddl…
7635d1d 
…e/Paddle into fleet_util
@123malin
test=develop, bug fix
2f5d31e
@123malin
test=develop, Merge branch 'develop' of https://github.com/PaddlePadd…
3038029 
…le/Paddle into fleet_util
@123malin
test=develop, conflit fix
a9a0308
@123malin
test=develop, bug fix
2e2fc65
@123malin
test=develop, bug fix
f5e056a
@123malin
test=develop, error message refine
87af8b7
@guru4elephant guru4elephant self-requested a review August 6, 2020 04:06
guru4elephant
guru4elephant approved these changes Aug 6, 2020
View reviewed changes
Copy link
Member

@guru4elephant guru4elephant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Heeenrrry
Heeenrrry approved these changes Aug 6, 2020
View reviewed changes
Copy link
Contributor

@Heeenrrry Heeenrrry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lanxianghit
Copy link
Contributor

直接移动，是不兼容升级？是否排查了受影响的任务和模型？models及各个模型库，CE，benchmark系统的模型是否受影响？

@seiriosPlus
Copy link
Collaborator

直接移动，是不兼容升级？是否排查了受影响的任务和模型？models及各个模型库，CE，benchmark系统的模型是否受影响？

不是移动， 原接口依然存在保证兼容性， models及各个模型库，CE，benchmark系统 不受影响

@seiriosPlus seiriosPlus merged commit 2191a08 into PaddlePaddle:develop Aug 7, 2020
jzhang533
jzhang533 reviewed Sep 11, 2020
View reviewed changes
python/requirements.txt
@@ -21,3 +21,4 @@ prettytable
objgraph
astor
pathlib
netifaces
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我看这里新引入了一个依赖。这会导致用户的安装体验下降， see： #27253
麻烦评估一下是否有其他实现方式可以不依赖netifaces。
@swtkiwi will discuss offline with @123malin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzhang533 jzhang533 jzhang533 left review comments

@seiriosPlus seiriosPlus seiriosPlus approved these changes

@kolinwei kolinwei kolinwei approved these changes

@Heeenrrry Heeenrrry Heeenrrry approved these changes

@guru4elephant guru4elephant guru4elephant approved these changes

@raindrops2sea raindrops2sea raindrops2sea approved these changes

@lanxianghit lanxianghit lanxianghit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@123malin @lanxianghit @seiriosPlus @jzhang533 @kolinwei @Heeenrrry @guru4elephant @raindrops2sea @WuHaobo