TracedLayer Error Message Enhancement #25734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
zhhsplendid
changed the title
Aurelius84
previously approved these changes
Jul 28, 2020
swtkiwi
reviewed
Jul 28, 2020
| for var in inputs: | ||
| _extract_vars(var, result_list) | ||
| else: | ||
| raise TypeError( | ||
| "The type of 'each element of inputs' in fluid.dygraph.jit.TracedLayer.trace must be fluid.Variable, but received {}.". |
There was a problem hiding this comment.
自2.0起，所有Variable不再对用户暴漏，全部使用“Tensor”哈～辛苦改下
There was a problem hiding this comment.
这里的是代码报错，当前代码还是Variable类型，恐怕不适合更改，你看这里还用Variable可以吗？
swtkiwi
reviewed
Jul 28, 2020
| @@ -1063,7 +1067,8 @@ def trace(layer, inputs): | |||
|
|
|||
| Args: | |||
| layer (dygraph.Layer): the layer object to be traced. | |||
| inputs (list(Variable)): the input variables of the layer object. | |||
| inputs (list(Variable)|tuple(Variable)|Variable): the input | |||
| variables of the layer object. | |||
|
|
|||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
APIs
Describe
Enhance TracedLayer Error Message
Note: this PR uses
assertto check type somewhere andcheck_typesomewhere, the reason is that thecheck_typeskips checking when it is under dygraph mode.