Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dy2stat] Modify print for dynamic type #25612

Merged
merged 2 commits into from
Jul 21, 2020
Merged

[Dy2stat] Modify print for dynamic type #25612

merged 2 commits into from
Jul 21, 2020

Conversation

zhhsplendid
Copy link
Member

@zhhsplendid zhhsplendid commented Jul 20, 2020 •
edited
Loading

PR types

New features

PR changes

APIs

Describe

Modify the print in Dy2stat for dynamic type. Unit test is covered in old test_print.py

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@zhhsplendid zhhsplendid changed the title [Dy2stat] Modify print for dynamic type, test=develop [Dy2stat] Modify print for dynamic type Jul 20, 2020
liym27
liym27 previously approved these changes Jul 20, 2020
View reviewed changes
Copy link
Contributor

@liym27 liym27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

chenwhql
chenwhql approved these changes Jul 20, 2020
View reviewed changes
Copy link
Contributor

@chenwhql chenwhql left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhhsplendid zhhsplendid merged commit 60da885 into PaddlePaddle:develop Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liym27 liym27 liym27 approved these changes

@chenwhql chenwhql chenwhql approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhhsplendid @chenwhql @liym27