Skip to content

Fix the argsort and sort api for the paddle api2.0 #25514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wawltor merged 8 commits into from
Jul 29, 2020
Merged

Fix the argsort and sort api for the paddle api2.0 #25514

wawltor merged 8 commits into from
Jul 29, 2020

Conversation

@wawltor
Copy link
Contributor

@wawltor wawltor commented Jul 14, 2020

PR types

Others

PR changes

APIs

Describe

Fix the sort and argsort the apis for the api2.0, and the dygraph example

@paddle-bot-old
Copy link

paddle-bot-old bot commented Jul 14, 2020

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

XiaoguangHu01
XiaoguangHu01 previously approved these changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

TCChenlong
TCChenlong previously approved these changes Jul 20, 2020
View reviewed changes
Copy link
Contributor

@TCChenlong TCChenlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor dismissed stale reviews from TCChenlong and XiaoguangHu01 via 19a87a5 July 20, 2020 11:33
TCChenlong
TCChenlong approved these changes Jul 29, 2020
View reviewed changes
Copy link
Contributor

@TCChenlong TCChenlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

FlyingQianMM
FlyingQianMM approved these changes Jul 29, 2020
View reviewed changes
Copy link
Contributor

@FlyingQianMM FlyingQianMM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

XiaoguangHu01
XiaoguangHu01 approved these changes Jul 29, 2020
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit dc42e3c into PaddlePaddle:develop Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TCChenlong TCChenlong TCChenlong approved these changes

@FlyingQianMM FlyingQianMM FlyingQianMM approved these changes

@XiaoguangHu01 XiaoguangHu01 XiaoguangHu01 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wawltor @TCChenlong @FlyingQianMM @XiaoguangHu01