Skip to content

arange API: start default is 0, end default is None #25452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 17, 2020
Merged

arange API: start default is 0, end default is None #25452

merged 7 commits into from
Jul 17, 2020

Conversation

zhupengyang
Copy link
Contributor

PR types

Others

PR changes

APIs

Describe

  • range
    • add name
  • arange
    • start default is 0
    • end default is None
  • update doc of range and arange

@paddle-bot-old
Copy link

paddle-bot-old bot commented Jul 9, 2020

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

qjing666
qjing666 previously approved these changes Jul 9, 2020
View reviewed changes
Copy link
Collaborator

@qjing666 qjing666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhupengyang zhupengyang force-pushed the arange-0708 branch 2 times, most recently from 742398b to 7b92750 Compare July 9, 2020 03:41
lanxianghit
lanxianghit reviewed Jul 14, 2020
View reviewed changes
@zhupengyang zhupengyang requested a review from lanxianghit July 14, 2020 03:43
lanxianghit
lanxianghit previously approved these changes Jul 14, 2020
View reviewed changes
Copy link
Contributor

@lanxianghit lanxianghit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhupengyang zhupengyang requested a review from swtkiwi July 15, 2020 02:04
swtkiwi
swtkiwi previously approved these changes Jul 15, 2020
View reviewed changes
Copy link
Contributor

@swtkiwi swtkiwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhupengyang zhupengyang dismissed stale reviews from swtkiwi and lanxianghit via 2f71741 July 15, 2020 02:26
lanxianghit
lanxianghit previously approved these changes Jul 15, 2020
View reviewed changes
swtkiwi
swtkiwi previously approved these changes Jul 15, 2020
View reviewed changes
Copy link
Contributor

@swtkiwi swtkiwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhupengyang zhupengyang dismissed stale reviews from swtkiwi and lanxianghit via f83f3d1 July 15, 2020 03:22
swtkiwi
swtkiwi approved these changes Jul 17, 2020
View reviewed changes
Copy link
Contributor

@swtkiwi swtkiwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhupengyang zhupengyang merged commit 5a2d15a into PaddlePaddle:develop Jul 17, 2020
@zhupengyang zhupengyang deleted the arange-0708 branch July 17, 2020 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swtkiwi swtkiwi swtkiwi approved these changes

@lanxianghit lanxianghit lanxianghit approved these changes

@qjing666 qjing666 qjing666 left review comments

@wangchaochaohu wangchaochaohu Awaiting requested review from wangchaochaohu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhupengyang @qjing666 @swtkiwi @lanxianghit