Add WITH_GOLANG to control the link of go lib #2530
Conversation
go/cmake/golang.cmake
Outdated
| if(APPLE) | ||
| set(LIB_NAME "lib${NAME}.dylib") | ||
| # set(LIB_NAME "lib${NAME}.dylib") | ||
| set(LIB_NAME "lib${NAME}.so") |
There was a problem hiding this comment.
compile library with .so suffix in Apple system, it will still generate apple arch binary but with .so suffix, is it runnable?
There was a problem hiding this comment.
Done, this is not a problem, we use _swig_paddle.so now, but I will not change this place in this pr, we can discuss it later.
CMakeLists.txt
Outdated
| add_subdirectory(go/pserver/cclient) | ||
|
|
||
| if(WITH_Go) | ||
| #add_subdirectory(go/pserver/cclient) |
There was a problem hiding this comment.
let's replace comment cmake code with TODO item. thanks
| add_simple_unittest(parameter_optimizer_test) | ||
| if(WITH_TESTING) | ||
| add_simple_unittest(serialization_test) | ||
| add_simple_unittest(parameter_optimizer_test) |
CMakeLists.txt
Outdated
| option(COVERALLS_UPLOAD "Package code coverage data to coveralls" OFF) | ||
| option(ON_TRAVIS "Exclude special unit test on Travis CI" OFF) | ||
| option(WITH_C_API "Compile PaddlePaddle with C-API(Prediction)" OFF) | ||
| option(WITH_Go "Compile PaddlePaddle with Go)" OFF) |
cmake/configure.cmake
Outdated
|
|
||
| if(NOT WITH_Go) | ||
| add_definitions(-DPADDLE_WITHOUT_GO) | ||
| endif() |
There was a problem hiding this comment.
Unified with other macros.
if(WITH_GOLANG)
add_definitions(-DPADDLE_WITH_GOLANG)
endif()
CMakeLists.txt
Outdated
| add_subdirectory(go/pserver/cclient) | ||
|
|
||
| if(WITH_Go) | ||
| #add_subdirectory(go/pserver/cclient) |
| DEPENDS ${filename} ${external_project_dependencies}) | ||
| endforeach() | ||
|
|
||
| include_directories(${CMAKE_CURRENT_BINARY_DIR}/proto) |
There was a problem hiding this comment.
because this dir is not exist
CMakeLists.txt
Outdated
| include_directories("${PROJ_ROOT}") | ||
| include_directories("${PROJ_ROOT}/paddle/cuda/include") | ||
| include_directories("${CMAKE_CURRENT_BINARY_DIR}/proto") | ||
| include_directories("${CMAKE_BINARY_DIR}/go/pserver/cclient") |
There was a problem hiding this comment.
{CMAKE_BINARY_DIR} -> ${CMAKE_CURRENT_BINARY_DIR}
There was a problem hiding this comment.
CMAKE_CURRENT_BINARY_DIR是当前便以文件所在目录，CMAKE_BINARY_DIR 是编译根目录，CMAKE_BINARY_DIR是不是更容易保证正确性？
3 participants
1, add WITH_Go to control build go lib into _swig_paddle.so.
2, temporarily disable go master because of some problem.