Skip to content

full Op:remove device, out and stop_gradient parameter test=develop #25257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jul 11, 2020
Merged

full Op:remove device, out and stop_gradient parameter test=develop #25257

merged 15 commits into from
Jul 11, 2020

Conversation

wangchaochaohu
Copy link
Contributor

@wangchaochaohu wangchaochaohu commented Jun 29, 2020 •
edited
Loading

PR types

Function optimization

PR changes

OPs

Describe

refine the API of full for 2.0(remove device, out and stop_gradient parameter ):

full(shape, fill_value, out=None, dtype=None, device=None, stop_gradient=True, name=None) ---> paddle.tensor.full(shape, fill_value, dtype=None, name=None)

zeros(shape, dtype, out=None, device=None) --->zeros(shape, dtype, name=None):

refine the error message

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

zhupengyang
zhupengyang reviewed Jul 6, 2020
View reviewed changes
@CLAassistant
Copy link

CLAassistant commented Jul 6, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Jul 7, 2020

Thanks for your contribution!
Please add test = develop in your commit message to trigger CI to ensure your PR can be merged.
See Paddle CI Manual for details.

zhupengyang
zhupengyang reviewed Jul 7, 2020
View reviewed changes
zhupengyang
zhupengyang reviewed Jul 7, 2020
View reviewed changes
zhupengyang
zhupengyang reviewed Jul 7, 2020
View reviewed changes
Copy link
Contributor

@zhupengyang zhupengyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

文档问题，其它pr可能也有，先一起改下吧

@zhupengyang zhupengyang self-requested a review July 7, 2020 08:38
zhupengyang
zhupengyang previously approved these changes Jul 8, 2020
View reviewed changes
Copy link
Contributor

@zhupengyang zhupengyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lanxianghit
lanxianghit previously approved these changes Jul 9, 2020
View reviewed changes
Copy link
Contributor

@lanxianghit lanxianghit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

swtkiwi
swtkiwi previously approved these changes Jul 10, 2020
View reviewed changes
Copy link
Contributor

@swtkiwi swtkiwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangchaochaohu wangchaochaohu dismissed stale reviews from swtkiwi, lanxianghit, and zhupengyang via 6a18afb July 10, 2020 02:26
zhupengyang
zhupengyang approved these changes Jul 10, 2020
View reviewed changes
Copy link
Contributor

@zhupengyang zhupengyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

swtkiwi
swtkiwi approved these changes Jul 10, 2020
View reviewed changes
Copy link
Contributor

@swtkiwi swtkiwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangchaochaohu wangchaochaohu merged commit bdc2c2d into PaddlePaddle:develop Jul 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swtkiwi swtkiwi swtkiwi approved these changes

@lanxianghit lanxianghit lanxianghit approved these changes

@zhupengyang zhupengyang zhupengyang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wangchaochaohu @CLAassistant @swtkiwi @lanxianghit @zhupengyang