[Dy2stat] Support Various-Length Return Grammar in Dy2stat #25249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… grammar_return test=develop
… variable_return, test=develop
|
Thanks for your contribution! |
Aurelius84
approved these changes
Jun 30, 2020
| @@ -239,11 +241,44 @@ def _restore_out(self, out_vars): | |||
| for i, idx in enumerate(self._outputs.var_ids): | |||
| flatten_outputs[idx] = out_vars[i] | |||
| outs = self._outputs.restore(flatten_outputs) | |||
| if len(outs) == 1: | |||
| if outs is not None and len(outs) == 1: | |||
| outs = outs[0] | |||
No, the rest corner case is related to dynamic shape and compile time check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Describe
Support Various-Length Return Grammar in Dy2stat. This PR is a follow-up of #25176 .
The basic idea is putting no-value placeholder variables at
returnstatement to make allreturnstatement have same length, after that the static graph can have fixed fetch output (code at return_transformer.py). Then remove those no-value placeholder when we finally return dygraph result (code at partial_program.py).However, various length return in Bert model is still not supported. The dy2stat can change the code as I wish but some ops which check shape at compile time (e.g. Reshape, MatMul) will throw error because of the no-value-placeholder may not have the required shape. Is this a matter? To me, those no-value placeholder will be replaced as really values meeting shape requirements at run time, so I think the solution should be some way to do the compile-time checking. By the way, every time when we have dynamic shape, it often causes problem in dy2stat. We should find a way to handle it in the future.
Fixing various return in Bert is my TODO thing and I will also find some other existing models for verification.