Repeat layer for column vector #2480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qingqing01
requested changes
Jun 16, 2017
| .. code-block:: python | ||
| concat = seq_concat_layer(a=layer1, b=layer2) | ||
| concat = seq_concat_layer(al=layer1, b=layer2) |
|
|
||
| CHECK_EQ(inputLayers_.size(), 1UL); | ||
| numFilters_ = config_.num_filters(); | ||
| asRowVector_ = config_.user_arg() != "as_col_vec"; |
Contributor
There was a problem hiding this comment.
user_arg had been defined in ModelConfig.proto. I note it for the first time. Just mark it. :)
| num_repeats, | ||
| as_row_vector=True, | ||
| name=None, | ||
| layer_attr=None): |
Contributor
There was a problem hiding this comment.
The activation is implemented in C++ code. Should we add it to the Python interface or remove it in C++ code?
Also remove active_type argument for many layers in config_parser.py because it is automatically handled by LayerBase.
Contributor
|
The |
lcy-seso
reviewed
Jun 19, 2017
Contributor
lcy-seso
left a comment
lcy-seso
left a comment
There was a problem hiding this comment.
The codes LGTM, though unittest is failed due to the missing file.
qingqing01
approved these changes
Jun 20, 2017
chen2016013
pushed a commit
to chen2016013/Paddle
that referenced
this pull request
Oct 17, 2025
Co-authored-by: Ace-To-HYB <huangyaobin@foxmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.