-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FixUnitTest] Fix a Batch Size Random Unit Test Failure #24718
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test=develop
…into fix_unit_test test=develop
Thanks for your contribution! |
❌This PR is not created using PR's template. |
test=develop
… fix_unit_test
… fix_unit_test
…ilure. test=develop
zhhsplendid
changed the title
Decrease the Batch Size of SE-Resnext in Unittest
[FixUnitTest] Fix a Batch Size Random Unit Test Failure
Jun 1, 2020
liym27
approved these changes
Jun 1, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Aurelius84
approved these changes
Jun 1, 2020
chalsliu
approved these changes
Jun 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required(必填, multiple choices, two at most)
PR type(PR 类型) is ( F ):
A. New features(新功能)---------------- D. Performance optimization(性能优化)
B. Bug fixes(问题修复)------------------ E. Breaking changes(向后不兼容的改变)
C. Function optimization(功能优化)------F. Others(其它)
PR changes(改动点)is ( D ):
A. OPs(operators)---------------------- C. Docs(文档)
B. APIs(接口)--------------------------- D. Others(其它)
Use one sentence to describe what this PR does.(简述本次PR的目的和改动)
The PR: #24651 seems causes new random failure of unit test test_parallel_executor_seresnext_base_cpu. The reason is that smaller batch size causes random optimization of neural network. I distinguished cpu/gpu batch size to fix the unittest.