try to fix unit test test_ProtoServer, test_TrainerOnePass #2414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix error: /paddle/paddle/.common_test_util.sh: line 97: netstat: command not found
helinwang
force-pushed
the
fix_unittest
branch
3 times, most recently
from
e894459 to
c03214e
Compare
wangkuiyi
approved these changes
Jun 7, 2017
| if (retry_second++ >= 7) { | ||
| LOG(FATAL) << "connection refused by pserver, maybe pserver failed!"; | ||
| } | ||
| std::this_thread::sleep_for(std::chrono::seconds(1)); |
There was a problem hiding this comment.
It seems that retry_second is defined by never used here. Should we make this line the following?
std::this_thread::sleep_fo(std::chrono::seconds(retry_seconds);There was a problem hiding this comment.
I think the retry_second in the code actually means "how many second we have retried", not a backoff strategy like "how many second to wait for current retry". Maybe change to retry_count is more clear.
There was a problem hiding this comment.
Done. Changed to retry_count.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2401