[Dy2stat] Rename Dygraph To Static Decorators #23880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
zhhsplendid
commented
Apr 15, 2020
•
zhhsplendid
commented
- Rename Dygraph To Static Decorators to declarative
- dygraph_to_static_func is still using in some training tests, I cannot delete it now.
- Add some API docs
test=develop
… rename_decorator test=develop
test=develop
test=develop
test=develop
… rename_decorator test=develop
test=develop
zhhsplendid
force-pushed
the
rename_decorator
branch
from
0e96f00 to
856a1e5
Compare
… rename_decorator test=develop
zhhsplendid
force-pushed
the
rename_decorator
branch
2 times, most recently
from
effa10c to
964184e
Compare
test=develop
zhhsplendid
force-pushed
the
rename_decorator
branch
from
964184e to
0a61b5a
Compare
liym27
reviewed
Apr 17, 2020
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
|
|
||
| Returns: | ||
| callable: converting imperative dygraph APIs into declarative | ||
| net-building APIs. |
There was a problem hiding this comment.
Better to capitalize the first letter of sentence in Args and Returns.
test=develop
… rename_decorator test=develop
zhhsplendid
added a commit
to zhhsplendid/Paddle
that referenced
this pull request
Apr 19, 2020
1. Rename Dygraph To Static Decorators to declarative 2. dygraph_to_static_func is still using in some training tests, I cannot delete it now. 3. Add some API docs
zhhsplendid
added a commit
that referenced
this pull request
Apr 19, 2020
zhhsplendid
added a commit
that referenced
this pull request
Apr 19, 2020
…anslator and Fix Related Bug (#23958) To prepare for publishing APIs, I added tests for that we can access dy2stat through: @fluid.dygraph.declarative @fluid.dygraph.jit.declarative fluid.dygraph.ProgramTranslator() fluid.dygraph.dygraph_to_static.ProgramTranslator() fluid.dygraph.dygraph_to_static.program_translator.ProgramTranslator() It surprised me that we had bugs on those different usages. I have fixed them. I also added example codes for these new APIs This PR also pulls my current PR #23880, so the PR history is long. For reviewer information, you could review this PR after #23880 is merged
zhhsplendid
added a commit
to zhhsplendid/Paddle
that referenced
this pull request
Apr 19, 2020
…anslator and Fix Related Bug (PaddlePaddle#23958) To prepare for publishing APIs, I added tests for that we can access dy2stat through: @fluid.dygraph.declarative @fluid.dygraph.jit.declarative fluid.dygraph.ProgramTranslator() fluid.dygraph.dygraph_to_static.ProgramTranslator() fluid.dygraph.dygraph_to_static.program_translator.ProgramTranslator() It surprised me that we had bugs on those different usages. I have fixed them. I also added example codes for these new APIs This PR also pulls my current PR PaddlePaddle#23880, so the PR history is long. For reviewer information, you could review this PR after PaddlePaddle#23880 is merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.