don't add unregisterd attr, test=develop #23047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phlrain
approved these changes
Mar 18, 2020
zhiqiu
added a commit
to zhiqiu/Paddle
that referenced
this pull request
Apr 2, 2020
* don't add unregisterd attr, test=develop * add some unittests,test=develop
sneaxiy
pushed a commit
that referenced
this pull request
Apr 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix #23028.
The problem is,
use_mkldnnis not a registered attribute inhard_sigmoid, and it will not be checked byTypedAttrChecker. So, when it is used inActivationGradOpMaker, errorRuntimeError: boost::bad_get: failed value get using boost::getis raised.We should not add
use_mkldnnto attrs if they are not given.