Fix div zero in fake quantize op #22966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fix_div_zero test=develop
heavengate
reviewed
Mar 13, 2020
| @@ -58,11 +58,12 @@ struct ClipAndFakeQuantFunctor<platform::CPUDeviceContext, T> { | |||
| const framework::Tensor& in, const framework::Tensor& scale, | |||
| const int bin_cnt, framework::Tensor* out) { | |||
| T s = scale.data<T>()[0]; | |||
| T inv_s = s - 0 <= 1e-30 ? 0 : 1.0 / s; | |||
There was a problem hiding this comment.
- s是否可能为负数，如果可能为负数建议用abs，不会为负数
-0建议不要 1e-30多处用到，建议作为全局常量放在.h里面
There was a problem hiding this comment.
建议在.h里面抽象一个HOSTDEVICE static inline的inverse函数
qingqing01
approved these changes
Mar 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix div zero in fake quantize op