Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polish grad op check #22290

Merged
merged 2 commits into from
Jan 15, 2020
Merged

Conversation

sneaxiy
Copy link
Collaborator

@sneaxiy sneaxiy commented Jan 15, 2020

This PR is designed to removing op_use_default_grad_op_maker.spec, because it relies on the compilation options (for example, match_matrix_tensor would only be compiled when WITH_MKL is on). Although we remove op_use_default_grad_op_maker.spec, we still monitor the changes of ops which use DefaultGradOpMaker in CI.

This PR changes paddle_build.sh to generate the develop version and pr version of op_use_default_grad_op_maker.spec. By comparing these 2 files, we can know whether the PR have added ops which use DefaultGradOpMaker.

To avoid conflicting with other PRs which changes op_use_default_grad_op_maker.spec, this PR only changes paddle_build.sh. I would remove op_use_default_grad_op_maker.spec in the next PR.

@sneaxiy sneaxiy force-pushed the polish_grad_op_check branch from 730d2f6 to fb534e8 Compare January 15, 2020 02:56
@sneaxiy sneaxiy force-pushed the polish_grad_op_check branch 2 times, most recently from 8a54e0e to cf89199 Compare January 15, 2020 05:42
@sneaxiy sneaxiy force-pushed the polish_grad_op_check branch from cf89199 to 3b54c3f Compare January 15, 2020 05:43
@sneaxiy sneaxiy requested review from luotao1 and zhangting2020 and removed request for zhangting2020 January 15, 2020 07:11
@sneaxiy sneaxiy merged commit 5e601a9 into PaddlePaddle:develop Jan 15, 2020
@sneaxiy sneaxiy deleted the polish_grad_op_check branch January 15, 2020 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants