Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run distributed tests parallely. #21751

Merged
merged 1 commit into from
Dec 15, 2019
Merged

Run distributed tests parallely. #21751

merged 1 commit into from
Dec 15, 2019

Conversation

gongweibao
Copy link
Contributor

Some days before, we run distributed tests serially to avoid the select port error. Since we fixed them and we can run them parallelly now.

@gongweibao gongweibao requested a review from luotao1 December 15, 2019 04:03
luotao1
luotao1 approved these changes Dec 15, 2019
View reviewed changes
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 549f24b into PaddlePaddle:develop Dec 15, 2019
luotao1
luotao1 reviewed Dec 15, 2019
View reviewed changes
python/paddle/fluid/tests/unittests/CMakeLists.txt
@@ -269,7 +269,7 @@ if(WITH_DISTRIBUTE)
set(dist_ut_port 1000)
foreach(TEST_OP ${DIST_TEST_OPS})
message(STATUS "set dist_ut_port=${dist_ut_port} on ${TEST_OP}")
bash_test_modules(${TEST_OP} MODULES dist_test.sh SERIAL LABELS "RUN_TYPE=EXCLUSIVE" ENVS "PADDLE_DIST_UT_PORT=${dist_ut_port}")
bash_test_modules(${TEST_OP} MODULES dist_test.sh LABELS "RUN_TYPE=EXCLUSIVE" ENVS "PADDLE_DIST_UT_PORT=${dist_ut_port}")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove RUN_TYPE=EXCLUSIVE?

@luotao1
Copy link
Contributor

luotao1 commented Dec 15, 2019

on the same machine, this PR decrease 10 minutes (987s-363s=624s=10m)

[05:44:21]	[Step 1/1] 
[05:44:21]	[Step 1/1] 100% tests passed, 0 tests failed out of 32
[05:44:21]	[Step 1/1] 
[05:44:21]	[Step 1/1] Label Time Summary:
[05:44:21]	[Step 1/1] RUN_TYPE=EXCLUSIVE    = 987.64 sec (32 tests)
[05:44:21]	[Step 1/1] 
[05:44:21]	[Step 1/1] Total Test time (real) = 987.69 sec
[05:44:21]	[Step 1/1] paddle_build script finished as expected

[04:58:20]	[Step 1/1] 100% tests passed, 0 tests failed out of 32
[04:58:20]	[Step 1/1] 
[04:58:20]	[Step 1/1] Label Time Summary:
[04:58:20]	[Step 1/1] RUN_TYPE=EXCLUSIVE    = 1080.81 sec (32 tests)
[04:58:20]	[Step 1/1] 
[04:58:20]	[Step 1/1] Total Test time (real) = 363.61 sec
[04:58:20]	[Step 1/1] paddle_build script finished as expected

@gongweibao gongweibao mentioned this pull request Dec 20, 2019
Merged
@wangxicoding wangxicoding mentioned this pull request Dec 25, 2019
Merged
@gongweibao gongweibao deleted the paralleldisttests branch January 17, 2021 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luotao1 luotao1 luotao1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gongweibao @luotao1