remove gfortran and dlopen lapack libs #1958
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gangliao
changed the title
Xreki
reviewed
May 2, 2017
paddle/math/MathFunctions.cpp
Outdated
| #else | ||
| return LAPACKE_sgetrf(order, M, N, A, lda, ipiv); | ||
| return dynload::LAPACKE_sgetrf(order, M, N, A, lda, ipiv); | ||
| #endif | ||
| #else | ||
| LOG(FATAL) << "Not implemented"; |
paddle/utils/DynamicLoad.cpp
Outdated
|
|
||
| void GetLapackDsoHandle(void** dso_handle) { | ||
| #if defined(__APPLE__) || defined(__OSX__) | ||
| GetDsoHandleFromSearchPath(FLAGS_warpctc_dir, "liblapack.dylib", dso_handle); |
There was a problem hiding this comment.
typo：FLAGS_warpctc_dir -> FLAGS_lapack_dir
hedaoyuan
reviewed
May 2, 2017
paddle/math/MathFunctions.cpp
Outdated
| @@ -87,9 +132,9 @@ int getrf<float>(const CBLAS_ORDER order, | |||
| int* ipiv) { | |||
| #ifdef PADDLE_USE_LAPACK | |||
There was a problem hiding this comment.
PADDLE_USE_LAPACK这个是否可以去掉了？
done
done
done
这个可以保留，ExternalProject_Add_Step只是copy了几个lapacke头文件, 这个lapacke.h在编译的时候，是需要的。 |
gangliao
changed the title
|
如果使用了动态装载的方式， 不需要。 |
|
@lzhao4ever 确实不需要了 |
emailweixu
pushed a commit
to emailweixu/Paddle
that referenced
this pull request
May 3, 2017
This only fixes the issue for ATLAS MKL is still another fix.
gangliao
added a commit
that referenced
this pull request
May 4, 2017
Fix dynamic loading of Lapack caused by #1958
heavengate
pushed a commit
to heavengate/Paddle
that referenced
this pull request
Aug 16, 2021
* add christmas application * fix element source
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
由于大多数情况下，用不到lapack的三个接口，然后编译lapack又需要使用gfortran，因此这里我们dlopen lapack动态库，如果运行时找不到库，再
apt-get install liblapacke-dev安装就行了，不需要编译引入复杂的gfrotran编译器以及库。