Skip to content

Conversation

@JiabinYang
Copy link
Contributor

This PR add api doc for digraph:

  1. BackwardStrategy
  2. no_grad
  3. guard
  4. to_variable
  5. Embedding
  6. NCE
  7. Prelu

@JiabinYang JiabinYang requested review from junjun315 and phlrain June 6, 2019 12:57
Copy link
Contributor

@junjun315 junjun315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comment

test_layer()
:param func
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one is a decorator so it’s parameter should be func

name(str|None): Name of Varaible
return:
None
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return var?

input = fluid.layers.data(name='ids', shape=[32, 32], dtype='float32')
embedding = fluid.Embedding(size=[dict_size, 16])
fc = embedding(input)
inp_word = np.array([[[1]]]).astype('int64')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[[[1]]] or [[1]] ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this one

Copy link
Contributor

@junjun315 junjun315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JiabinYang JiabinYang merged commit 4d5f693 into PaddlePaddle:develop Jun 9, 2019
@JiabinYang JiabinYang deleted the feature/refine_api_for_dygraph branch January 18, 2021 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants