-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Feature/refine api for dygraph #17907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/refine api for dygraph #17907
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some comment
python/paddle/fluid/dygraph/base.py
Outdated
| test_layer() | ||
| :param func |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this one is a decorator so it’s parameter should be func
python/paddle/fluid/dygraph/base.py
Outdated
| name(str|None): Name of Varaible | ||
| return: | ||
| None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return var?
| input = fluid.layers.data(name='ids', shape=[32, 32], dtype='float32') | ||
| embedding = fluid.Embedding(size=[dict_size, 16]) | ||
| fc = embedding(input) | ||
| inp_word = np.array([[[1]]]).astype('int64') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[[[1]]] or [[1]] ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR add api doc for digraph:
BackwardStrategyno_gradguardto_variableEmbeddingNCEPrelu