Skip to content

fix deconv2d bug for cycle_gan #17554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 11, 2019
Merged

fix deconv2d bug for cycle_gan #17554

merged 4 commits into from
Jun 11, 2019

Conversation

@tink2123
Copy link
Contributor

@tink2123 tink2123 commented May 22, 2019

fix #17425

@JiabinYang JiabinYang self-requested a review May 22, 2019 04:18
junjun315
junjun315 approved these changes Jun 10, 2019
View reviewed changes
Copy link
Contributor

@junjun315 junjun315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, It's better to add notes where the stop_gradient are made.

@tink2123 tink2123 closed this Jun 10, 2019
@tink2123 tink2123 reopened this Jun 10, 2019
@junjun315 junjun315 merged commit ed118ee into PaddlePaddle:develop Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@junjun315 junjun315 junjun315 approved these changes

@JiabinYang JiabinYang Awaiting requested review from JiabinYang

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

动态图如果不指定 conv2d_transpose 的 output_size 会报错

2 participants

@tink2123 @junjun315