Function Adds some properties #1216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianbingsz
approved these changes
Jan 26, 2017
Contributor
tianbingsz
left a comment
tianbingsz
left a comment
There was a problem hiding this comment.
LGTM. Approve it to move fast.
|
|
||
| check(inputs, outputs); | ||
| // ArgType check still on here, | ||
| // not sure whether it is better to put inside the check. |
Contributor
There was a problem hiding this comment.
I think we can move the CHECK of argType into check funciton.
Contributor
Author
There was a problem hiding this comment.
我觉得先放calc里面吧，API的参数可能跟ASSIGN_TO/ADD_TO有关，放这里会清楚一些。
| // And some Functions have the same input and output shapes, | ||
| // so you may not need to enter the complete number of arguments. | ||
| // But entering the full arguments is always correct for this interface. | ||
| virtual size_t ops(const BufferArgs& inputs, const BufferArgs& outputs) { |
Contributor
There was a problem hiding this comment.
Can we use timestamp to measure the running time of the operators?
Contributor
Author
There was a problem hiding this comment.
嗯，后续再考虑如何获取运行实现，这里先描述operators数。
zhhsplendid
pushed a commit
to zhhsplendid/Paddle
that referenced
this pull request
Sep 25, 2019
* Polish executor doc
wangxicoding
pushed a commit
to wangxicoding/Paddle
that referenced
this pull request
Dec 9, 2021
lizexu123
pushed a commit
to lizexu123/Paddle
that referenced
this pull request
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add FunctionBase::ops() and FunctionBase::check()
实现ISSUE中的特性
#892 (comment)