Add brpc serialization support. #11430
Conversation
gongweibao
changed the title
gongweibao
requested review from
Yancey0623,
panyx0718 and
typhoonzero
and removed request for
panyx0718 and
typhoonzero
typhoonzero
left a comment
typhoonzero
left a comment
There was a problem hiding this comment.
LGTM basically, but still need a way to check this through CI later.
| iobuf->append(reinterpret_cast<char*>(&k), 4); | ||
| iobuf->append(reinterpret_cast<char*>(&vlen), 8); | ||
|
|
||
| // FIXME(gongwb): use append_zerocopy |
There was a problem hiding this comment.
why cannot use this? need brpc support?
There was a problem hiding this comment.
We changed tensor memory holder, and brpc didn't support destroy userdata but only support destroy the payload data.
| PADDLE_ENFORCE_NOT_NULL(payload); | ||
|
|
||
| // FIXME(gongwb): it seems that can use zero copy. | ||
| if (var_is_not_stable) { |
There was a problem hiding this comment.
what var_is_not_stable means?
There was a problem hiding this comment.
When a var is a temp variable, it's memory can be free out, so we can't append only a pointer but copy data.
Yuyang change it tensor data holder to sharedptr and then this not useful.I'll clean up next pr.
|
|
gongweibao
force-pushed
the
brpcserial
branch
3 times, most recently
from
a6be0a7 to
ddbd878
Compare
test=develop
test=develop
The macro should be defined by compiler rather than by source. test=develop
test=develop
test=develop
test=develop
test=develop
test=develop
test=develop fix visualizer test=develop add push test=develop add push test=develop clean up test=develop
test=develop
gongweibao
force-pushed
the
brpcserial
branch
from
b60199a to
8c58ede
Compare
gongweibao
force-pushed
the
brpcserial
branch
from
a57508e to
f459d4a
Compare
| if (it != rpc_call_map.end()) { | ||
| request_send_h_ = it->second; | ||
| send_threads_.reset(new paddle::framework::ThreadPool( | ||
| rpc_server_->GetThreadNum(distributed::kRequestSend))); |
There was a problem hiding this comment.
can use FLAGS_rpc_send_thread_num etc
There was a problem hiding this comment.
The caller will use FLAGS_rpc_send_thread_num to register this property and it use the arguments.
12 participants
Fix part of #10804