Add merge_ids_op #11342
Merged
Add merge_ids_op #11342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
… add-merge-splited-ids
… add-merge-splited-ids
Yancey0623
reviewed
Jun 13, 2018
| @@ -330,8 +330,12 @@ void Executor::RunPreparedContext(ExecutorPrepareContext* ctx, Scope* scope, | |||
| } | |||
|
|
|||
| for (auto& op : ctx->ops_) { | |||
| VLOG(3) << place_ << " " << op->DebugStringEx(local_scope); | |||
| VLOG(4) << place_ << " " << op->DebugStringEx(local_scope); | |||
There was a problem hiding this comment.
Can we keep the log level before op run and after?
| AddComment(R"DOC( | ||
| Merge multi LoDTensor's into one according to Ids's shard num. | ||
| The values in the input LoDTensor are lookuped from the output of split_ids_op | ||
|
|
There was a problem hiding this comment.
How about adding some comments to explain why X0 is mapped to index 3 and 6.
typhoonzero
reviewed
Jun 13, 2018
| // copy data from ins[shard_num] to out. | ||
| for (int i = 0; i < ids_dims[0]; ++i) { | ||
| int64_t id = ids[i]; | ||
| size_t shard_id = static_cast<size_t>(id) % shard_num; |
There was a problem hiding this comment.
Hash method is currently hardcoded, just a message for notice.
There was a problem hiding this comment.
yes, will be an independent module in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
project: #10868
dist lookup table返回的结果需要merge在一起，之前用的concat是不对的，会打乱结果的顺序，merge_ids参考原始Id的顺序才能把结果正确的merge在一起，同时也把lod信息拷贝给merge的结果。