Skip to content

fix test error in fluid_benchmark.py #11184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
luotao1 merged 1 commit into from
Jun 5, 2018
Merged

fix test error in fluid_benchmark.py #11184

luotao1 merged 1 commit into from
Jun 5, 2018

Conversation

@luotao1
Copy link
Contributor

@luotao1 luotao1 commented Jun 5, 2018

fix #11163

  • The reason is that batch_acc != None is None, so use batch_acc directly.
  • fix typo of no_test meaning, and its action. The original meaning and action are both reversed. After fixing, the default run.sh will test the testset during the training.
  • Add , at the end of line 232, thus, line 232 and line 237 will be printed in the same line.

@luotao1 luotao1 requested a review from typhoonzero June 5, 2018 05:59
typhoonzero
typhoonzero approved these changes Jun 5, 2018
View reviewed changes
Copy link
Contributor

@typhoonzero typhoonzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

@luotao1 luotao1 merged commit 6ada5f4 into PaddlePaddle:develop Jun 5, 2018
@luotao1 luotao1 deleted the benchmark1 branch June 5, 2018 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@typhoonzero typhoonzero typhoonzero approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

float() argument must be a string or a number

2 participants

@luotao1 @typhoonzero