simplify inference api #11104
Merged
simplify inference api #11104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panyx0718
requested changes
Jun 1, 2018
| // Create variables | ||
| // TODO(panyx0718): Why need to test share_variables here? | ||
| if (config_.share_variables) { | ||
| executor_->CreateVariables(*inference_program_, scope_.get(), 0); |
panyx0718
reviewed
Jun 1, 2018
| &feed_targets, | ||
| &fetch_targets, | ||
| !config_.share_variables); | ||
| true /*create_variable*/); |
Contributor
There was a problem hiding this comment.
if share_variable is true, this should be false by default?
Superjomn
commented
Jun 1, 2018
| // API. | ||
| // TODO(Superjomn) this should be modified when `Clone` is valid for | ||
| // multi-thread application. | ||
| executor_->CreateVariables(*inference_program_, scope_.get(), 0); |
Contributor
Author
There was a problem hiding this comment.
I've restored the CreateVariable here. @panyx0718
panyx0718
approved these changes
Jun 1, 2018
| int device; | ||
| float fraction_of_gpu_memory; | ||
| int device{0}; | ||
| float fraction_of_gpu_memory{-1.f}; // Negative to notify initialization. |
Contributor
There was a problem hiding this comment.
I suggest the default one to be a workable value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.