Skip to content

fix build capi failed #10694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 16, 2018
Merged

fix build capi failed #10694

merged 2 commits into from
May 16, 2018

Conversation

Yancey0623
Copy link
Contributor

Fixed #10673
Fixed #10664

@Yancey0623 Yancey0623 requested review from luotao1 and wanglei828 May 16, 2018 07:35
luotao1
luotao1 reviewed May 16, 2018
View reviewed changes
paddle/fluid/CMakeLists.txt Outdated
add_subdirectory(recordio)
# NOTE: please add subdirectory inference at last.
add_subdirectory(inference)
ENDIF()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

改在https://github.com/PaddlePaddle/Paddle/blob/develop/paddle/CMakeLists.txt#L28 是不是更好一点？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是的，多谢提醒, done.

luotao1
luotao1 approved these changes May 16, 2018
View reviewed changes
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！

@Yancey0623 Yancey0623 merged commit 4473eff into PaddlePaddle:develop May 16, 2018
@Yancey0623 Yancey0623 deleted the fix_build_capi branch May 16, 2018 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@luotao1 luotao1 luotao1 approved these changes

@wanglei828 wanglei828 Awaiting requested review from wanglei828

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Yancey0623 @luotao1