Skip to content

Conversation

typhoonzero
Copy link
Contributor

@typhoonzero typhoonzero commented May 14, 2018

fix #10584

GIT_TAG "v0.14"
PREFIX ${MKLDNN_SOURCES_DIR}
UPDATE_COMMAND ""
PATCH_COMMAND ${CMAKE_COMMAND} -E copy_if_different ${CMAKE_CURRENT_SOURCE_DIR}/patches/mkldnn.hpp ${MKLDNN_SOURCES_DIR}/src/extern_mkldnn/include/mkldnn.hpp
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add a comment here to explain why we use the patch.
The related issue is in uxlfoundation/oneDNN#237.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@luotao1 luotao1 added the Intel label May 14, 2018
@typhoonzero typhoonzero changed the title [Test] patch mkldnn for build on gcc 4.8.2 Patch mkldnn for build on gcc 4.8.2 May 14, 2018
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@typhoonzero typhoonzero merged commit b3e5a88 into PaddlePaddle:develop May 14, 2018
@typhoonzero typhoonzero deleted the patch_mkldnn branch May 14, 2018 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mkldnn compiler error in gcc48

2 participants