feature/inference analysis dot #10494
Conversation
Superjomn
force-pushed
the
feature/inference-framework
branch
from
e812ab6 to
c4739d0
Compare
There was a problem hiding this comment.
这个注释不够准确。models是由python/paddle/fluid/tests/book生成的，写成tests/book，会认为是paddle/fluid/inference/tests/book生成的。
这个注释可以放到23行前，因为这里两个test目录都依赖生成的模型。
There was a problem hiding this comment.
.h不用写在cmake里面，改成
cc_library(inference_analysis SRCS node.cc graph_traits.cc data_flow_graph.cc dot.cc)
There was a problem hiding this comment.
- 现在的写法，不能分开测试
node_tester,dot_tester,data_flow_graph_tester - 11-18行的依赖可以直接使用{FLUID_CORE_MODULES}, https://github.com/PaddlePaddle/Paddle/blob/develop/paddle/fluid/inference/CMakeLists.txt#L1
- 对dot_tester和node_tester来说，它们不需要依赖fluid代码就可以跑，
cc_test(dot_tester SRCS dot_tester.cc dot.cc)
cc_test(node_tester SRCS node_tester.cc node.cc)
cc_test(data_flow_graph_tester SRCS data_flow_graph_tester.cc data_flow_graph_tester.cc DEPS ${FLUID_CORE_MODULES})
There was a problem hiding this comment.
dot.cc 可以删去，20行实现在dot.h里面即可。
There was a problem hiding this comment.
reference https://stackoverflow.com/questions/18860895/how-to-initialize-static-members-in-the-header
the static member should be booted in a src.
There was a problem hiding this comment.
A registry helper class keeps the order they register?
python/paddle/fluid/metrics.py
Outdated
There was a problem hiding this comment.
node_tester.cc没有内容的话，可以先删掉。
There was a problem hiding this comment.
some nodes can have a name：为什么有些可以有名字，有些没有呢？
There was a problem hiding this comment.
Value 有名字，Function没有； 类比 variable 有名字，OP没有名字
Superjomn
force-pushed
the
feature/inference-framework
branch
from
c4739d0 to
52e6b20
Compare
There was a problem hiding this comment.
NOTE that the new node types should be added here.
There was a problem hiding this comment.
- kNone是用在什么地方呢？
- kFunction->kOp?
- kFunctionBlock->kBlock?
There was a problem hiding this comment.
1.style filled是表示什么？
2.One Node type can customize its own node？是说每一种node type都有自定义？
Superjomn
changed the title
|
|
||
| if(WITH_TESTING) | ||
| add_subdirectory(tests/book) | ||
| # analysis test depends the models that generate by python/paddle/fluid/tests/book |
There was a problem hiding this comment.
24行放到23行前面
both tests/book and analysis depend on the models that generated by python/paddle/fluid/tests/book
| @@ -0,0 +1 @@ | |||
| cc_test(test_dot SRCS dot.cc dot.h dot_tester.cc) | |||
There was a problem hiding this comment.
cc_test(test_dot SRCS dot.cc dot_tester.cc)
不需要.h
| TEST_F(DotTester, Build) { | ||
| auto codes = dot->Build(); | ||
| // Output the DOT language code, the generated codes are too long to compare | ||
| // the string. |
…/inference-framework
2 participants
This is the framework for inference analysis
This PR is a part of the full code.