Skip to content

Conversation

panyx0718
Copy link
Contributor

No description provided.

@panyx0718 panyx0718 requested review from Superjomn and Xreki May 5, 2018 12:58
Superjomn
Superjomn previously approved these changes May 5, 2018
Copy link
Contributor

@Superjomn Superjomn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


####################
# Inference tests here depend on fluid/tests/book
# User need to run tests in fluid/tests/book first to generate saved model.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line 22 set_tests_properties(test_inference_${TARGET_NAME}${arg} PROPERTIES DEPENDS test_${TARGET_NAME}) already do this depends. So users need not to manually run tests to generated saved model before.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But when I ran "ctest -R test_inference_word2vec", the test failed. After I ran "ctest -R test_word2vec", then ran "ctest -R test_inference_word2vec", it passed.
Does the "DEPENDS" really work?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we use make test to run all the unittests, this DEPENDS can make sure the order. However, if users want to run ctest -R test_inference_word2vec separately, he need to run ctest -R test_word2vec manually first.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for explain. Updated the comments.

@Xreki Xreki added the 预测 原名Inference,包含Capi预测问题等 label May 7, 2018
Copy link
Contributor

@Xreki Xreki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@panyx0718 panyx0718 merged commit 0c51888 into PaddlePaddle:develop May 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

预测 原名Inference,包含Capi预测问题等

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants