Trainer save load params #10386
Merged
Trainer save load params #10386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jetfuel
requested review from
abhinavarora,
reyoung,
helinwang,
daming-lu and
sidgoyal78
sidgoyal78
reviewed
May 3, 2018
python/paddle/fluid/trainer.py
Outdated
| @@ -124,7 +124,10 @@ def test(self, reader): | |||
|
|
|||
| def save_params(self, param_path): | |||
| # reference: save_persistables in io.py | |||
| pass | |||
| exe = executor.Executor(self.place) | |||
| exe.run(self.startup_program, scope=self.scope) | |||
There was a problem hiding this comment.
I am not sure if we need this. I guess save_persistables will call save_vars which will run the executor (
Paddle/python/paddle/fluid/io.py
Line 129 in 0ecc6fa
There was a problem hiding this comment.
Ah I see. So
save_program = Program()
save_block = save_program.global_block()
already loads all the variables from the scope?
…ram to the load_persistables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixs #10310