Improve trainer API #10354
Merged
Improve trainer API #10354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helinwang
requested review from
JiayiFeng,
abhinavarora,
cs2be,
reyoung,
sidgoyal78 and
wangkuiyi
This was referenced May 2, 2018
- The trainer and inferencer will load params from disk if param_path argument is not None in their constructor. - Remove params.py, we will expose core.Scope to the user if needed (e.g., for GAN). Currently we will not expose it, unless we clearly know doing so can support GAN. - Add `save_params` to Trainer (a TODO item). - rename "network" to "program"
reyoung
approved these changes
May 3, 2018
Collaborator
reyoung
left a comment
reyoung
left a comment
There was a problem hiding this comment.
Excellent. It is a good skeleton to implement API.
reyoung
reviewed
May 3, 2018
|
|
||
| if avg_cost < 5.0: | ||
| trainer.params.save(save_path) | ||
| trainer.save_params(save_path) |
Collaborator
There was a problem hiding this comment.
Not only save_params should be supported in the trainer, but also save_checkpoint should be supported by the trainer to restore training progress.
We can add another PR to add this API.
Contributor
Author
There was a problem hiding this comment.
Sure, thank you for pointing out!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #10352
The trainer and inferencer will load params from disk if param_path
argument is not None in their constructor (API changed, implementation TODO)
Remove params.py, we will expose core.Scope to the user if needed
(e.g., for GAN). Currently we will not expose it, unless we clearly
know doing so can support GAN.
Add
save_paramsto Trainer (API changed, implementation TODO)rename "network" to "program"