Refine distribute transpiler api #10342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yancey0623
changed the title
typhoonzero
reviewed
May 2, 2018
| op.input("Param")[0]), | ||
| self.origin_program.global_block().var( | ||
| op.input("Grad")[0]))) | ||
| elif op.type == "scale": |
There was a problem hiding this comment.
Can you use ufind here to find the connected ops so that we can remove this hack here?
There was a problem hiding this comment.
we only need scale op here, but ufind will find too many ops such as fc and fc_grad.
There was a problem hiding this comment.
I saw get_pserver_program also have similar code, can you put this in a private function?
|
Thanks! I will update #10316 according after this gets merged. |
typhoonzero
approved these changes
May 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #10341