Skip to content

Conversation

@cs2be
Copy link
Contributor

@cs2be cs2be commented May 1, 2018

No description provided.

Copy link
Contributor

@sidgoyal78 sidgoyal78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, this looks good. Are we going to merge into develop?

Copy link
Contributor

@jetfuel jetfuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


def event_handler(event):
if isinstance(event, fluid.EndIteration):
if (event.batch_id % 10) == 0:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad that we have batch_id return in the event.

def main(use_cuda):
if use_cuda and not fluid.core.is_compiled_with_cuda():
return
save_path = "image_classification_resnet.inference.model"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use save_path actually make the program easier to read. Nice!
Now we can split the train and infer functions

@cs2be cs2be merged commit fb7ca48 into PaddlePaddle:develop May 1, 2018
@cs2be cs2be deleted the SIMPLIFY_IMAGE_RECOGNITION_TEST branch May 1, 2018 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants