Clean cross entropy #10280
Merged
Clean cross entropy #10280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chengduoZH
reviewed
Apr 28, 2018
| : dx_(dx), dy_(dy), x_(x), label_(label), num_classes_(num_classes) {} | ||
|
|
||
| HOSTDEVICE void operator()(size_t label_id) { | ||
| auto x_is_true_offset = label_id * num_classes_ + label_[label_id]; |
There was a problem hiding this comment.
Maybe label_id is not exact, sample_id may be better.
| dx_[x_offset] = x_offset != x_is_true_offset | ||
| ? static_cast<T>(0) | ||
| : -dy_[label_id] / x_[x_offset]; | ||
| } |
There was a problem hiding this comment.
I prefer to write like this:
auto x_is_true_offset = label_id * num_classes_ + label_[label_id];
dx_[x_is_true_offset] = -dy_[label_id] / x_[x_is_true_offset]
and put setting dx_ to zero in here.
There was a problem hiding this comment.
It is slower to use two kernels than one kernel.
… feature/add_stable_test_of_cross_entropy
…:reyoung/Paddle into feature/add_stable_test_of_cross_entropy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unify cross entropy CPU and GPU kernel by
platform::ForRangefunctor. It reduce the lines of code ofcross_entropy_op