Fix more CPPlint issues in fluid/operators/math #10249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhinavarora
changed the title
abhinavarora
requested review from
cs2be,
jacquesqiao,
sidgoyal78 and
wangkuiyi
chengduoZH
reviewed
Apr 27, 2018
Contributor
There was a problem hiding this comment.
Please pay attention to the parameter order.
When ordering function parameters, put all input-only parameters before any output parameters. I
https://google.github.io/styleguide/cppguide.html#Output_Parameters
Contributor
Author
There was a problem hiding this comment.
Done. Thank you for the feedback.
abhinavarora
force-pushed
the
cpplint_math
branch
from
a4b1148 to
642702a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.