Skip to content

fix build activation_op.cc on mac #10116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jacquesqiao merged 1 commit into from
Apr 21, 2018
Merged

fix build activation_op.cc on mac #10116

jacquesqiao merged 1 commit into from
Apr 21, 2018

Conversation

@jacquesqiao
Copy link
Member

@jacquesqiao jacquesqiao commented Apr 21, 2018

The latest code build failed on MacOS.

/Users/qiaolongfei/project/paddle/paddle/fluid/operators/activation_op.cc:84:16: error: unused variable 'LogSigmoidDoc' [-Werror,-Wunused-const-variable]
constexpr char LogSigmoidDoc[] = R"DOC(
               ^
/Users/qiaolongfei/project/paddle/paddle/fluid/operators/activation_op.cc:91:16: error: unused variable 'ExpDoc' [-Werror,-Wunused-const-variable]
constexpr char ExpDoc[] = R"DOC(

@jacquesqiao jacquesqiao requested a review from dzhwinter April 21, 2018 14:36
dzhwinter
dzhwinter approved these changes Apr 21, 2018
View reviewed changes
Copy link
Contributor

@dzhwinter dzhwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@jacquesqiao jacquesqiao merged commit 3aacde2 into PaddlePaddle:develop Apr 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dzhwinter dzhwinter dzhwinter approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jacquesqiao @dzhwinter