-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Added kernel to Beam Search OP #10052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e36f2ec to
8abbb3d
Compare
8f30c50 to
64509fd
Compare
Merge remote-tracking branch 'upstream/develop' into fix-10026
Merge branch 'fix-10026' of github.com:ktlichkid/Paddle into fix-10026
Superjomn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| auto scores_var = scope.FindVar(Input("scores")); | ||
| auto pre_ids_var = scope.FindVar(Input("pre_ids")); | ||
| void Compute(const framework::ExecutionContext& context) const override { | ||
| auto ids_var = context.Input<framework::LoDTensor>("ids"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
auto => auto*
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
jacquesqiao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
resolve #10026