-
Notifications
You must be signed in to change notification settings - Fork 45
Fix output_dir of dtype generalization pass #624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里可以和其他pass一样,使用rel_model_path
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
收到
| "weight_meta.py", | ||
| "input_meta.py", | ||
| "input_tensor_constraints.py", | ||
| "graph_hash.txt", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
graph_hash.txt应该是使用model.py的代码生成的:
from graph_net.hash_util import get_sha256_hash
file_hash = get_sha256_hash(py_code)
(Path(model_path) / "graph_hash.txt").write_text(file_hash)
另外,作用于子图的话,还有个subgraph_sources.json需要拷贝,这样原始样本里面没有,你直接一起拷贝哈。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
subgraph_sources.json是还没有是吗,我直接copy了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
subgraph_sources.json原始整图样本里面没有,子图样本里面会存在,你判断下存在就拷贝。
| output_sample_dir.mkdir(parents=True, exist_ok=True) | ||
|
|
||
| # Copy all files | ||
| for fname in [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里和 L404 都有对样本文件的拷贝,考虑优化下代码
|
还有一处,也请一起修改下吧,就是样本试跑, |
Xreki
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR Category
other
Description
Fix outpit_dir of dtype generalization pass