Skip to content

[BugFix] Set enable_cache_output as false by default#5751

Merged
Jiang-Jia-Jun merged 1 commit into
PaddlePaddle:developfrom
rainyfly:set_cache_output_to_false_by_default
Dec 24, 2025
Merged

[BugFix] Set enable_cache_output as false by default#5751
Jiang-Jia-Jun merged 1 commit into
PaddlePaddle:developfrom
rainyfly:set_cache_output_to_false_by_default

Conversation

@rainyfly
Copy link
Copy Markdown
Collaborator

@rainyfly rainyfly commented Dec 24, 2025

Motivation

测试发现开启缓存输出时,会偶现报错,暂时默认关闭缓存输出功能。

Modifications

设置缓存输出功能的默认值为 False

Usage or Command

None

Accuracy Tests

None

Checklist

  • Add at least a tag in the PR title.
    • Tag list: [[FDConfig],[APIServer],[Engine], [Scheduler], [PD Disaggregation], [Executor], [Graph Optimization], [Speculative Decoding], [RL], [Models], [Quantization], [Loader], [OP], [KVCache], [DataProcessor], [BugFix], [Docs], [CI], [Optimization], [Feature], [Benchmark], [Others], [XPU], [HPU], [GCU], [DCU], [Iluvatar], [Metax]]
    • You can add new tags based on the PR content, but the semantics must be clear.
  • Format your code, run pre-commit before commit.
  • Add unit tests. Please write the reason in this PR if no unit tests.
  • Provide accuracy results.
  • If the current PR is submitting to the release branch, make sure the PR has been submitted to the develop branch, then cherry-pick it to the release branch with the [Cherry-Pick] PR tag.

Copilot AI review requested due to automatic review settings December 24, 2025 09:52
@paddle-bot
Copy link
Copy Markdown

paddle-bot Bot commented Dec 24, 2025

Thanks for your contribution!

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

这个PR修复了一个与缓存输出相关的bug,将 enable_output_caching 的默认值从 True 改为 False,以避免偶现的错误。

  • 修改 EngineArgs 类中 enable_output_caching 字段的默认值
  • 使 args_utils.py 中的默认值与 config.py 保持一致
  • 不影响显式启用该功能的测试用例

Comment thread fastdeploy/engine/args_utils.py
Comment thread fastdeploy/engine/args_utils.py
@rainyfly rainyfly changed the title [Bug fix] Set enable_cache_output as false by default [BugFix] Set enable_cache_output as false by default Dec 24, 2025
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (develop@e75f93d). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #5751   +/-   ##
==========================================
  Coverage           ?   65.93%           
==========================================
  Files              ?      330           
  Lines              ?    41832           
  Branches           ?     6409           
==========================================
  Hits               ?    27583           
  Misses             ?    12207           
  Partials           ?     2042           
Flag Coverage Δ
GPU 65.93% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Jiang-Jia-Jun Jiang-Jia-Jun merged commit b90a922 into PaddlePaddle:develop Dec 24, 2025
21 of 24 checks passed
ckl117 pushed a commit to fxyfxy777/FastDeploy that referenced this pull request Dec 29, 2025
chang-wenbin pushed a commit to chang-wenbin/FastDeploy that referenced this pull request Mar 2, 2026
xiaoguoguo626807 pushed a commit to xiaoguoguo626807/FastDeploy that referenced this pull request May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants