[BugFix] fix cuda version #5202
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
yuanlehome
previously approved these changes
Nov 24, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5202 +/- ##
==========================================
Coverage ? 59.89%
==========================================
Files ? 317
Lines ? 38806
Branches ? 5853
==========================================
Hits ? 23242
Misses ? 13724
Partials ? 1840
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Jiang-Jia-Jun
previously approved these changes
Nov 25, 2025
yuanlehome
reviewed
Nov 26, 2025
Comment on lines
+1802
to
+1810
| if self.eplb_config is not None and self.eplb_config.enable_eplb: | ||
| try: | ||
| import cuda # noqa | ||
| except Exception: | ||
| raise ImportError( | ||
| "cuda-python not installed. Install the version matching your CUDA toolkit:\n" | ||
| " CUDA 12.x → pip install cuda-python==12.*\n" | ||
| " CUDA 11.x → pip install cuda-python==11.*" | ||
| ) |
Collaborator
There was a problem hiding this comment.
我理解这块可能得放在这里，实际import的时候，以后这个库不一定仅在eplb下才会使用到
Collaborator
Author
There was a problem hiding this comment.
但这样有可能会在运行时报错，对问题排查不友好？后续其他场景需要import 可以在config->check 中增加判断？
yuanlehome
reviewed
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
为支持多cuda版本，取消固定 cuda-python 版本，在使用eplb时，让用户手动下载对应版本的cuda-python
Modifications
Usage or Command
Accuracy Tests
Checklist
[FDConfig],[APIServer],[Engine],[Scheduler],[PD Disaggregation],[Executor],[Graph Optimization],[Speculative Decoding],[RL],[Models],[Quantization],[Loader],[OP],[KVCache],[DataProcessor],[BugFix],[Docs],[CI],[Optimization],[Feature],[Benchmark],[Others],[XPU],[HPU],[GCU],[DCU],[Iluvatar],[Metax]]pre-commitbefore commit.releasebranch, make sure the PR has been submitted to thedevelopbranch, then cherry-pick it to thereleasebranch with the[Cherry-Pick]PR tag.