Skip to content

Conversation

@juncaipeng
Copy link
Collaborator

@juncaipeng juncaipeng commented Nov 24, 2025

Motivation

Add unittest
拆分PR: https://github.com/PaddlePaddle/FastDeploy/pull/5027/files

Modifications

Add unittest

Usage or Command

不变

Accuracy Tests

不需要

Checklist

  • Add at least a tag in the PR title.
    • Tag list: [[FDConfig],[APIServer],[Engine], [Scheduler], [PD Disaggregation], [Executor], [Graph Optimization], [Speculative Decoding], [RL], [Models], [Quantization], [Loader], [OP], [KVCache], [DataProcessor], [BugFix], [Docs], [CI], [Optimization], [Feature], [Benchmark], [Others], [XPU], [HPU], [GCU], [DCU], [Iluvatar], [Metax]]
    • You can add new tags based on the PR content, but the semantics must be clear.
  • Format your code, run pre-commit before commit.
  • Add unit tests. Please write the reason in this PR if no unit tests.
  • Provide accuracy results.
  • If the current PR is submitting to the release branch, make sure the PR has been submitted to the develop branch, then cherry-pick it to the release branch with the [Cherry-Pick] PR tag.

Copilot AI review requested due to automatic review settings November 24, 2025 07:05
@paddle-bot
Copy link

paddle-bot bot commented Nov 24, 2025

Thanks for your contribution!

Copilot finished reviewing on behalf of juncaipeng November 24, 2025 07:08
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds RDMA (Remote Direct Memory Access) support for splitwise deployment in PD (Prefill-Decode) disaggregation scenarios. The PR introduces a new end-to-end test for RDMA-based cache transfer and includes a shell script utility for detecting RDMA-capable network interfaces.

Key Changes:

  • Added RDMA network interface detection script (get_rdma_nics.sh) to identify appropriate NICs for different hardware configurations
  • Implemented comprehensive E2E test (test_ernie_03b_pd_router_v1_rdma.py) for splitwise deployment using RDMA protocol for cache transfer
  • Fixed minor issues in existing IPC-based test (corrected log file names and function call)

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 17 comments.

File Description
tests/e2e/utils/get_rdma_nics.sh New shell script that detects RDMA-capable network interfaces for GPU, XPU, CPU, and virtual configurations to enable RDMA-based cache transfer
tests/e2e/test_ernie_03b_pd_router_v1_rdma.py New E2E test suite that validates splitwise deployment with RDMA protocol, testing both streaming and non-streaming chat/completion endpoints
tests/e2e/test_ernie_03b_pd_router_v1_ipc.py Minor improvements: updated comment for clarity, fixed log filenames for consistency, and corrected cleanup function call

@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (develop@2d78759). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #5189   +/-   ##
==========================================
  Coverage           ?   59.74%           
==========================================
  Files              ?      317           
  Lines              ?    38795           
  Branches           ?     5842           
==========================================
  Hits               ?    23177           
  Misses             ?    13776           
  Partials           ?     1842           
Flag Coverage Δ
GPU 59.74% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@juncaipeng juncaipeng changed the title [PD Disaggregation] Add splitwise deployment with using rdma [PD Disaggregation] Add unittest for splitwise deployment with using rdma Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants