[BugFix] fix mm_positions type error #5182
Merged
+17
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5182 +/- ##
==========================================
Coverage ? 59.74%
==========================================
Files ? 317
Lines ? 38688
Branches ? 5815
==========================================
Hits ? 23115
Misses ? 13747
Partials ? 1826
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lizhenyun01
previously approved these changes
Nov 25, 2025
Jiang-Jia-Jun
requested changes
Nov 25, 2025
fastdeploy/engine/request.py
Outdated
| and "mm_positions" in d["multimodal_inputs"] | ||
| and isinstance(d["multimodal_inputs"]["mm_positions"], list) | ||
| and len(d["multimodal_inputs"]["mm_positions"]) > 0 | ||
| and not isinstance(d["multimodal_inputs"]["mm_positions"][0], ImagePosition) |
Collaborator
There was a problem hiding this comment.
这么复杂的条件，建议写成一个小的判断函数，也能知道这里判断的作用是什么
Collaborator
Author
There was a problem hiding this comment.
看了一下，from_dict是一个 classmethod 方法，不太适合调用类中的机器方法，还是写在里边比较好。简化了一下判断逻辑，同时加了注释，能清晰一些
Jiang-Jia-Jun
previously approved these changes
Nov 25, 2025
5 tasks
Jiang-Jia-Jun
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
将ds下发的mm_positions dict类型转换为ImagePosition 类型
Modifications
Usage or Command
Accuracy Tests
Checklist
[FDConfig],[APIServer],[Engine],[Scheduler],[PD Disaggregation],[Executor],[Graph Optimization],[Speculative Decoding],[RL],[Models],[Quantization],[Loader],[OP],[KVCache],[DataProcessor],[BugFix],[Docs],[CI],[Optimization],[Feature],[Benchmark],[Others],[XPU],[HPU],[GCU],[DCU],[Iluvatar],[Metax]]pre-commitbefore commit.releasebranch, make sure the PR has been submitted to thedevelopbranch, then cherry-pick it to thereleasebranch with the[Cherry-Pick]PR tag.