[DEBUG] Add more log to debug interface #5172
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks for your contribution! |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds debug logging to the weight update interface to help distinguish which port requests are coming from in multi-DP (Data Parallel) scenarios.
- Adds logging at the entry point of
update_model_weightandclear_load_weightfunctions - Logs the return status codes (200, 404) for each execution path
- Includes contextual information (port number and error messages) in all log entries
| update model weight | ||
| """ | ||
| if app.state.dynamic_load_weight: | ||
| api_server_logger.info(f"Recevice command: update_model_weight in port: {args.port}") |
There was a problem hiding this comment.
Spelling error: "Recevice" should be "Receive".
| """ | ||
| clear model weight | ||
| """ | ||
| api_server_logger.info(f"Recevice command: clear_load_weight in port: {args.port}") |
There was a problem hiding this comment.
Spelling error: "Recevice" should be "Receive".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
增加更多日志以便于debug权重更新接口
Motivation
当前多DP无法区分请求来源于哪个端口，增加日志区分
Modifications
Usage or Command
Accuracy Tests
Checklist
[FDConfig],[APIServer],[Engine],[Scheduler],[PD Disaggregation],[Executor],[Graph Optimization],[Speculative Decoding],[RL],[Models],[Quantization],[Loader],[OP],[KVCache],[DataProcessor],[BugFix],[Docs],[CI],[Optimization],[Feature],[Benchmark],[Others],[XPU],[HPU],[GCU],[DCU],[Iluvatar],[Metax]]pre-commitbefore commit.releasebranch, make sure the PR has been submitted to thedevelopbranch, then cherry-pick it to thereleasebranch with the[Cherry-Pick]PR tag.