[CI] 【Hackathon 9th Sprint No.41】NO.41 功能模块单测补充 -part by xunyoyo · Pull Request #5062 · PaddlePaddle/FastDeploy

xunyoyo · 2025-11-15T10:48:44Z

This commit introduces a comprehensive test suite for the SplitwiseConnector class, implementing various tests to ensure the correct functionality of task dispatching, message sending, and connection handling. The tests cover scenarios for both prefill and decode roles, including checks for task promotion, message serialization, and error handling.

Motivation

NO.41 功能模块 fastdeploy/splitwise/splitwise_connector.py 单测补充

Modifications

new dir and add tests/splitwise/test_splitwise_connector.py

Usage or Command

tests/splitwise/test_splitwise_connector.py:

python -m coverage run -m unittest tests.splitwise.test_splitwise_connector \
&& python -m coverage report -m --include='fastdeploy/splitwise/splitwise_connector.py'

Accuracy Tests

原覆盖:

File	Stmts	Miss	Branch	BrPart	Cover(%)
fastdeploy/splitwise/splitwise_connector.py	251	211	92	2	12

tests/splitwise/test_splitwise_connector.py:

Name                                          Stmts   Miss  Cover   Missing
---------------------------------------------------------------------------
fastdeploy/splitwise/splitwise_connector.py     251     42    83%   90-108, 144, 158, 160, 166-167, 189, 192-194, 265, 276, 278,
 280, 282-285, 308, 338-339, 381, 408, 410, 417, 421-422
---------------------------------------------------------------------------
TOTAL                                           251     42    83%

覆盖 ++169 行

Checklist

Add at least a tag in the PR title.
- Tag list: [[FDConfig],[APIServer],[Engine], [Scheduler], [PD Disaggregation], [Executor], [Graph Optimization], [Speculative Decoding], [RL], [Models], [Quantization], [Loader], [OP], [KVCache], [DataProcessor], [BugFix], [Docs], [CI], [Optimization], [Feature], [Benchmark], [Others], [XPU], [HPU], [GCU], [DCU], [Iluvatar], [Metax]]
- You can add new tags based on the PR content, but the semantics must be clear.
Format your code, run pre-commit before commit.
Add unit tests. Please write the reason in this PR if no unit tests.
Provide accuracy results.
If the current PR is submitting to the release branch, make sure the PR has been submitted to the develop branch, then cherry-pick it to the release branch with the [Cherry-Pick] PR tag.

This commit introduces a comprehensive test suite for the SplitwiseConnector class, implementing various tests to ensure the correct functionality of task dispatching, message sending, and connection handling. The tests cover scenarios for both prefill and decode roles, including checks for task promotion, message serialization, and error handling.

paddle-bot · 2025-11-15T10:48:50Z

Thanks for your contribution!

Copilot

Pull Request Overview

This PR adds comprehensive unit tests for the SplitwiseConnector class as part of Hackathon 9th Sprint No.41, achieving 82% code coverage for the fastdeploy/splitwise/splitwise_connector.py module. The tests verify task dispatching, message sending, and connection handling across various scenarios including prefill/decode roles, RDMA/IPC protocols, and error conditions.

Key Changes

Adds 15 test cases covering core SplitwiseConnector functionality
Implements mock classes and fixtures to isolate the connector from external dependencies
Tests both innode (local) and remote communication paths

Copilot · 2025-11-15T10:53:57Z

+    class _Logger:
+        def info(self, *_, **__):
+            return None
+
+        def warning(self, *_, **__):
+            return None
+
+        def debug(self, *_, **__):
+            return None
+
+        def error(self, *_, **__):
+            return None


The _Logger class should have a docstring explaining its purpose as a mock logger for testing. This helps maintainability by clarifying why we're using stub methods instead of actual logging.

Copilot · 2025-11-15T10:53:57Z

+    queue.available_prefill_instances.size = 1
+    assert connector.has_splitwise_tasks() is False
+    queue.available_prefill_instances.size = 0
+    assert connector.has_splitwise_tasks() is True


The assertion uses is False and is True for boolean comparisons. While this works, it's more Pythonic and recommended to use the simpler assert not connector.has_splitwise_tasks() and assert connector.has_splitwise_tasks() for boolean assertions, as per PEP 8 guidelines.

Suggested change

assert connector.has_splitwise_tasks() is True

assert connector.has_splitwise_tasks()

Copilot · 2025-11-15T10:53:57Z

+    dummy = DummySocket()
+    connector.push_sockets = {"test": dummy}
+    connector._close_connection("test")
+    assert dummy.closed is True


The assertion uses is True. It's more Pythonic to use assert dummy.closed for boolean assertions.

Suggested change

assert dummy.closed is True

assert dummy.closed

Copilot · 2025-11-15T10:53:58Z

+class _FakeAvailableQueue:
+    def __init__(self):
+        self.size = 0
+
+    def qsize(self):
+        return self.size
+
+
+class FakeEngineWorkerQueue:
+    def __init__(self, *_, **__):
+        self.disaggregated_tasks = []
+        self.cache_infos = []
+        self.available_prefill_instances = _FakeAvailableQueue()
+        self.prefill_ready = False
+
+    def get_prefill_instances(self):
+        return 1 if self.prefill_ready else 0
+
+    def put_disaggregated_tasks(self, payload):
+        self.disaggregated_tasks.append(copy.deepcopy(payload))
+
+    def put_cache_info(self, payload):
+        self.cache_infos.append(copy.deepcopy(payload))
+
+
+class InspectableConnector(SplitwiseConnector):
+    def __init__(self, *args, **kwargs):
+        self.sent_messages = []
+        super().__init__(*args, **kwargs)
+
+    def _send_message(self, addr, msg_type: str, payload):  # pragma: no cover - overridden for tests
+        self.sent_messages.append((addr, msg_type, copy.deepcopy(payload)))
+
+
+class DummyTask:
+    def __init__(self, request_id, disaggregate_info, block_tables=None, idx=0, need_prefill_tokens=0):
+        self.request_id = request_id
+        self.disaggregate_info = disaggregate_info
+        self.block_tables = block_tables or []
+        self.idx = idx
+        self.need_prefill_tokens = need_prefill_tokens
+        self.error_msg = None
+
+    def get(self, key, default=None):
+        return getattr(self, key, default)
+
+
+class _StubSocket:
+    def __init__(self, kind):
+        self.kind = kind
+        self.closed = False
+        self.bound = None
+        self.connected = None
+        self.sent = []
+        self.should_fail = False
+
+    def setsockopt(self, *_, **__):
+        return None
+
+    def bind(self, address):
+        self.bound = address
+
+    def connect(self, address):
+        self.connected = address
+
+    def send_multipart(self, payload):
+        if self.should_fail:
+            raise ValueError("send failure")
+        self.sent.append(payload)
+
+    def close(self):
+        self.closed = True
+
+    def recv_multipart(self):  # pragma: no cover - not needed for tests
+        return []
+
+
+class _StubContext:
+    def __init__(self):
+        self.sockets: list[_StubSocket] = []
+
+    def socket(self, kind):
+        sock = _StubSocket(kind)
+        self.sockets.append(sock)
+        return sock
+
+
+class _StubPoller:
+    def __init__(self):
+        self.registered = []
+
+    def register(self, socket, event):
+        self.registered.append((socket, event))
+
+    def poll(self, timeout):  # pragma: no cover - not used in tests
+        return []
+


Mock/fake classes used for testing should have docstrings explaining their purpose. Please add docstrings to _FakeAvailableQueue, FakeEngineWorkerQueue, InspectableConnector, DummyTask, _StubSocket, _StubContext, and _StubPoller classes to improve test maintainability.

Copilot · 2025-11-15T10:53:58Z

+def make_cfg(
+    innode_ports=None,
+    pd_comm_port=None,
+    *,
+    enable_expert_parallel=False,
+    data_parallel_size=1,
+    local_data_parallel_id=0,
+):
+    parallel_config = SimpleNamespace(
+        enable_expert_parallel=enable_expert_parallel,
+        data_parallel_size=data_parallel_size,
+        local_data_parallel_id=local_data_parallel_id,
+        engine_worker_queue_port=[6100],
+        tensor_parallel_size=1,
+        device_ids="0,1",
+    )
+    cache_config = SimpleNamespace(pd_comm_port=pd_comm_port)
+    disaggregate_info = {
+        "cache_info": {"rdma": {"ip": "10.0.0.5", "port": 9001, "rdma_port": [12345], "current_id": None}}
+    }
+    return SimpleNamespace(
+        parallel_config=parallel_config,
+        cache_config=cache_config,
+        host_ip="127.0.0.1",
+        disaggregate_info=disaggregate_info,
+        innode_prefill_ports=innode_ports,
+    )
+
+
+def make_task(request_id, role="prefill", protocol="rdma"):
+    cache_info = {}
+    if protocol == "rdma":
+        cache_info["rdma"] = {"ip": "10.1.0.1", "port": 9010, "current_id": None}
+    else:
+        cache_info["ipc"] = {"ip": "0.0.0.0", "port": 9200, "current_id": 7}
+    disaggregate_info = {
+        "role": role,
+        "transfer_protocol": protocol,
+        "cache_info": cache_info,
+    }
+    if role == "decode":
+        disaggregate_info["block_tables"] = [f"decode-{request_id}"]
+    block_tables = [f"blk-{request_id}"]
+    return DummyTask(request_id, disaggregate_info, block_tables=block_tables, idx=3, need_prefill_tokens=5)
+
+
+def make_request_obj(request_id="req", **overrides):
+    payload = dict(
+        request_id=request_id,
+        prompt="hi",
+        prompt_token_ids=[1],
+        prompt_token_ids_len=1,
+        messages=None,
+        history=None,
+        tools=None,
+        system=None,
+        eos_token_ids=None,
+        arrival_time=0.0,
+    )
+    payload.update(overrides)
+    return Request(sampling_params=SamplingParams(), **payload)
+


Helper functions should have docstrings explaining their parameters and return values. Please add docstrings to make_cfg(), make_task(), and make_request_obj() to document what they create and how to use them.

Copilot · 2025-11-15T10:53:59Z

+import copy
+import importlib.machinery
+import json
+import sys
+import types
+from pathlib import Path
+from types import SimpleNamespace
+
+import pytest
+
+PROJECT_ROOT = Path(__file__).resolve().parents[2]
+if str(PROJECT_ROOT) not in sys.path:
+    sys.path.insert(0, str(PROJECT_ROOT))
+
+if "fastdeploy" not in sys.modules:
+    fastdeploy_pkg = types.ModuleType("fastdeploy")


The test file is missing a copyright header and module docstring. Based on other test files in this repository (e.g., tests/engine/test_sampling_params.py), all test files should include:

A copyright header with the Apache 2.0 license

A module-level docstring describing the purpose of the tests

Example format:

""" # Copyright (c) 2025 PaddlePaddle Authors. All Rights Reserved. # # Licensed under the Apache License, Version 2.0 (the "License" # you may not use this file except in compliance with the License. # You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law or agreed to in writing, software # distributed under the License is distributed on an "AS IS" BASIS, # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # See the License for the specific language governing permissions and # limitations under the License. """

Copilot · 2025-11-15T10:53:59Z

+    class _Counter:
+        def __init__(self):
+            self.value = 0
+
+        def inc(self, amount: int = 1):
+            self.value += amount


The _Counter class should have a docstring explaining that it's a mock implementation of a metrics counter for testing purposes.

Copilot · 2025-11-15T10:53:59Z

+def test_has_splitwise_tasks_detects_prefill_backlog():
+    cfg = make_cfg(innode_ports=[7001])
+    worker_queue = FakeEngineWorkerQueue()
+    connector = InspectableConnector(cfg, worker_queue, object())
+    connector.create_connection(7001)
+    queue = connector.connect_innode_instances[7001]
+    queue.available_prefill_instances.size = 1
+    assert connector.has_splitwise_tasks() is False
+    queue.available_prefill_instances.size = 0
+    assert connector.has_splitwise_tasks() is True
+
+
+def test_dispatch_innode_splitwise_tasks_promotes_decode_role():
+    cfg = make_cfg(innode_ports=[8002])
+    worker_queue = FakeEngineWorkerQueue()
+    connector = InspectableConnector(cfg, worker_queue, object())
+    connector.create_connection(8002)
+    queue = connector.connect_innode_instances[8002]
+    queue.prefill_ready = True
+    task = make_task("req-dispatch", role="prefill", protocol="ipc")
+    connector.dispatch_innode_splitwise_tasks([task], current_id=33)
+    assert queue.disaggregated_tasks[-1][0] == "prefill"
+    assert task.disaggregate_info["role"] == "decode"
+    assert task.disaggregate_info["cache_info"]["ipc"]["current_id"] == 33
+
+
+def test_send_splitwise_tasks_dispatches_when_innode_ports_available():
+    cfg = make_cfg(innode_ports=[8100])
+    worker_queue = FakeEngineWorkerQueue()
+    connector = InspectableConnector(cfg, worker_queue, object())
+    connector.create_connection(8100)
+    connector.connect_innode_instances[8100].prefill_ready = True
+    task = make_task("req-prefill", role="prefill", protocol="ipc")
+    connector.send_splitwise_tasks([task], current_id=44)
+    assert connector.connect_innode_instances[8100].disaggregated_tasks
+
+
+def test_send_splitwise_tasks_innode_rewrites_ports_for_decode_queue():
+    cfg = make_cfg()
+    worker_queue = FakeEngineWorkerQueue()
+    connector = InspectableConnector(cfg, worker_queue, object())
+    connector.create_connection(8123)
+    task = make_task("req-innode", role="decode", protocol="ipc")
+    snapshot_port = connector.send_splitwise_tasks_innode([task], 8123)
+    recorded = connector.connect_innode_instances[8123].disaggregated_tasks[-1]
+    assert snapshot_port == 8123
+    assert (
+        recorded[1][0].disaggregate_info["cache_info"]["ipc"]["port"]
+        == cfg.parallel_config.engine_worker_queue_port[0]
+    )
+    assert task.disaggregate_info["cache_info"]["ipc"]["port"] == 8123
+
+
+def test_send_splitwise_tasks_rdma_routes_and_resets_state():
+    cfg = make_cfg()
+    worker_queue = FakeEngineWorkerQueue()
+    connector = InspectableConnector(cfg, worker_queue, object())
+    task = make_task("req-remote", role="prefill", protocol="rdma")
+    connector.send_splitwise_tasks([task], current_id=55)
+    assert connector.sent_messages[-1][0] == "10.1.0.1:9010"
+    assert connector.sent_messages[-1][1] == "prefill"
+    assert connector.current_request_ids["req-remote"] == "init"
+    assert task.disaggregate_info["role"] == "prefill"
+
+
+def test_send_cache_infos_prefill_batches_into_worker_queue():
+    cfg = make_cfg()
+    worker_queue = FakeEngineWorkerQueue()
+    connector = InspectableConnector(cfg, worker_queue, object())
+    task = make_task("req-prefill", role="prefill", protocol="ipc")
+    was_decode = connector.send_cache_infos([task], current_id=11)
+    assert was_decode is False
+    assert worker_queue.cache_infos[-1][0]["request_id"] == "req-prefill"
+    assert worker_queue.cache_infos[-1][0]["current_id"] == 11
+
+
+def test_send_cache_infos_decode_rdma_triggers_remote_sync():
+    cfg = make_cfg()
+    worker_queue = FakeEngineWorkerQueue()
+    connector = InspectableConnector(cfg, worker_queue, object())
+    task = make_task("req-decode", role="decode", protocol="rdma")
+    result = connector.send_cache_infos([task], current_id=22)
+    assert result is True
+    assert connector.sent_messages[-1][1] == "cache_sync"
+    assert worker_queue.cache_infos == []
+
+
+def test_send_cache_infos_decode_ipc_forwards_to_local_worker():
+    cfg = make_cfg()
+    worker_queue = FakeEngineWorkerQueue()
+    connector = InspectableConnector(cfg, worker_queue, object())
+    connector.create_connection(9300)
+    task = make_task("req-local", role="decode", protocol="ipc")
+    task.disaggregate_info["cache_info"]["ipc"]["port"] = 9300
+    connector.send_cache_infos([task], current_id=7)
+    assert connector.connect_innode_instances[9300].cache_infos[-1][0]["transfer_protocol"] == "ipc"
+
+
+def test_send_cache_infos_rdma_with_error_message_forwards_reason():
+    cfg = make_cfg()
+    worker_queue = FakeEngineWorkerQueue()
+    connector = InspectableConnector(cfg, worker_queue, object())
+    task = make_task("req-err", role="decode", protocol="rdma")
+    task.error_msg = "remote boom"
+    connector.send_cache_infos([task], current_id=0)
+    assert connector.sent_messages[-1][1] == "cache_sync"
+    assert "error_msg" in connector.sent_messages[-1][2][0]
+
+
+def test_send_first_token_to_ipc_decode_queue():
+    cfg = make_cfg()
+    worker_queue = FakeEngineWorkerQueue()
+    connector = InspectableConnector(cfg, worker_queue, object())
+    connector.create_connection(9400)
+    msg = {"transfer_protocol": "ipc", "cache_info": {"ipc": {"port": 9400}}}
+    task = make_task("req-first", role="decode", protocol="ipc")
+    connector.send_first_token(msg, [task])
+    assert connector.connect_innode_instances[9400].disaggregated_tasks[-1][0] == "decode"
+
+
+def test_send_first_token_rdma_path(monkeypatch):
+    cfg = make_cfg()
+    worker_queue = FakeEngineWorkerQueue()
+    connector = InspectableConnector(cfg, worker_queue, object())
+    msg = {
+        "transfer_protocol": "rdma",
+        "cache_info": {"rdma": {"ip": "1.2.3.4", "port": 9123}},
+    }
+    task = make_task("req-first-rdma", role="decode", protocol="rdma")
+    connector.send_first_token(msg, task)
+    assert connector.sent_messages[-1][0] == "1.2.3.4:9123"
+    assert connector.sent_messages[-1][1] == "decode"
+
+
+def test_check_decode_allocated_reports_finish_and_error():
+    cfg = make_cfg()
+    worker_queue = FakeEngineWorkerQueue()
+    connector = InspectableConnector(cfg, worker_queue, object())
+    task = make_task("req-finish", role="prefill", protocol="rdma")
+    connector.current_request_ids["req-finish"] = "finished"
+    ok, msg = connector.check_decode_allocated(task)
+    assert ok and msg == ""
+    task2 = make_task("req-error", role="prefill", protocol="rdma")
+    connector.current_request_ids["req-error"] = "failed"
+    ok2, msg2 = connector.check_decode_allocated(task2)
+    assert ok2 is False and msg2 == "failed"
+
+
+def test_process_cache_sync_records_status_and_forwards(monkeypatch):
+    cfg = make_cfg()
+    worker_queue = FakeEngineWorkerQueue()
+    connector = InspectableConnector(cfg, worker_queue, object())
+    payload = [
+        {"request_id": "req-a", "error_msg": "boom"},
+        {"request_id": "req-b"},
+    ]
+    message = json.dumps({"type": "cache_sync", "payload": payload}).encode("utf-8")
+    connector._process_message(message)
+    assert connector.current_request_ids["req-a"] == "boom"
+    assert connector.current_request_ids["req-b"] == "finished"
+    assert worker_queue.cache_infos[-1] == payload
+
+
+def test_handle_prefill_and_decode_messages():
+    cfg = make_cfg()
+    worker_queue = FakeEngineWorkerQueue()
+    connector = InspectableConnector(cfg, worker_queue, object())
+    req = make_request_obj("req-handle")
+    connector._handle_prefill([req.to_dict()])
+    assert worker_queue.disaggregated_tasks[-1][0] == "decode"
+    completion = CompletionOutput(index=0, send_idx=0, token_ids=[])
+    metrics = RequestMetrics(arrival_time=0.0)
+    output = RequestOutput("req-out", outputs=completion, metrics=metrics)
+    connector._handle_decode([output.to_dict()])
+    assert worker_queue.disaggregated_tasks[-1][0] == "decode"
+
+
+def test_close_connection_removes_socket_reference():
+    cfg = make_cfg()
+    worker_queue = FakeEngineWorkerQueue()
+    connector = InspectableConnector(cfg, worker_queue, object())
+
+    class DummySocket:
+        def __init__(self):
+            self.closed = False
+
+        def close(self):
+            self.closed = True
+
+    dummy = DummySocket()
+    connector.push_sockets = {"test": dummy}
+    connector._close_connection("test")
+    assert dummy.closed is True
+    assert connector.push_sockets == {}
+
+
+def test_send_message_initializes_network_and_serializes(monkeypatch):
+    monkeypatch.setattr(splitwise_connector, "zmq", _make_stub_zmq())
+
+    class DummyExecutor:
+        def __init__(self, *_, **__):
+            self.calls = []
+
+        def submit(self, fn, *args, **kwargs):
+            self.calls.append((fn, args, kwargs))
+
+    monkeypatch.setattr(splitwise_connector, "ThreadPoolExecutor", DummyExecutor)
+
+    cfg = make_cfg(pd_comm_port=[9550], enable_expert_parallel=True, data_parallel_size=2, local_data_parallel_id=1)
+    worker_queue = FakeEngineWorkerQueue()
+    connector = SplitwiseConnector(cfg, worker_queue, object())
+    output = RequestOutput("req-zmq")
+    connector._send_message("127.0.0.1:9551", "decode", [output])
+    sock = connector.push_sockets["127.0.0.1:9551"]
+    assert json.loads(sock.sent[-1][1].decode("utf-8"))["type"] == "decode"
+
+
+def test_send_message_handles_failures_and_resets_socket(monkeypatch):
+    monkeypatch.setattr(splitwise_connector, "zmq", _make_stub_zmq())
+    monkeypatch.setattr(splitwise_connector, "ThreadPoolExecutor", lambda *_, **__: None)
+    cfg = make_cfg(pd_comm_port=[9660])
+    worker_queue = FakeEngineWorkerQueue()
+    connector = SplitwiseConnector(cfg, worker_queue, object())
+    failing_socket = _StubSocket(2)
+    failing_socket.should_fail = True
+    connector.push_sockets["node"] = failing_socket
+    splitwise_connector.main_process_metrics.send_cache_failed_num.value = 0
+    output = RequestOutput("req-fail")
+    connector._send_message("node", "decode", [output])
+    assert "node" not in connector.push_sockets
+    assert splitwise_connector.main_process_metrics.send_cache_failed_num.value == 1


Test functions should have docstrings describing what they're testing and what the expected behavior is. This is especially important for complex test cases. Following the pattern in tests/engine/test_sampling_params.py, each test function should include a docstring explaining the scenario being tested.

Copilot · 2025-11-15T10:54:00Z

+PROJECT_ROOT = Path(__file__).resolve().parents[2]
+if str(PROJECT_ROOT) not in sys.path:
+    sys.path.insert(0, str(PROJECT_ROOT))
+
+if "fastdeploy" not in sys.modules:
+    fastdeploy_pkg = types.ModuleType("fastdeploy")
+    fastdeploy_pkg.__path__ = [str(PROJECT_ROOT / "fastdeploy")]
+    fastdeploy_pkg.__spec__ = importlib.machinery.ModuleSpec("fastdeploy", loader=None, is_package=True)
+    sys.modules["fastdeploy"] = fastdeploy_pkg
+
+if "paddle" not in sys.modules:
+    paddle_stub = types.ModuleType("paddle")
+    paddle_dist = types.ModuleType("paddle.distributed")
+    paddle_stub.distributed = paddle_dist
+    paddle_stub.Tensor = type("Tensor", (), {})
+    sys.modules["paddle"] = paddle_stub
+    sys.modules["paddle.distributed"] = paddle_dist
+
+if "fastdeploy.utils" not in sys.modules:
+
+    class _Logger:
+        def info(self, *_, **__):
+            return None
+
+        def warning(self, *_, **__):
+            return None
+
+        def debug(self, *_, **__):
+            return None
+
+        def error(self, *_, **__):
+            return None
+
+    utils_stub = types.ModuleType("fastdeploy.utils")
+    utils_stub.get_logger = lambda *_, **__: _Logger()
+    utils_stub.data_processor_logger = _Logger()
+    utils_stub.scheduler_logger = _Logger()
+    utils_stub.llm_logger = _Logger()
+    sys.modules["fastdeploy.utils"] = utils_stub
+
+if "fastdeploy.metrics" not in sys.modules:
+    metrics_pkg = types.ModuleType("fastdeploy.metrics")
+    metrics_pkg.__path__ = [str(PROJECT_ROOT / "fastdeploy" / "metrics")]
+    metrics_pkg.__spec__ = importlib.machinery.ModuleSpec("fastdeploy.metrics", loader=None, is_package=True)
+    sys.modules["fastdeploy.metrics"] = metrics_pkg
+
+if "fastdeploy.metrics.metrics" not in sys.modules:
+    metrics_module = types.ModuleType("fastdeploy.metrics.metrics")
+
+    class _Counter:
+        def __init__(self):
+            self.value = 0
+
+        def inc(self, amount: int = 1):
+            self.value += amount
+
+    metrics_module.main_process_metrics = types.SimpleNamespace(send_cache_failed_num=_Counter())
+    sys.modules["fastdeploy.metrics.metrics"] = metrics_module
+
+from fastdeploy.engine.request import (
+    CompletionOutput,
+    Request,
+    RequestMetrics,
+    RequestOutput,
+)
+from fastdeploy.engine.sampling_params import SamplingParams
+from fastdeploy.splitwise import splitwise_connector
+from fastdeploy.splitwise.splitwise_connector import SplitwiseConnector


The manual sys.path manipulation and module stubbing (lines 11-68) is complex and could be fragile. Consider using pytest fixtures or proper test isolation instead of manually injecting stubs into sys.modules at import time. This approach makes the test file harder to maintain and could cause issues if tests are run in different orders or if modules are already loaded.

Suggested change

PROJECT_ROOT = Path(__file__).resolve().parents[2]

if str(PROJECT_ROOT) not in sys.path:

sys.path.insert(0, str(PROJECT_ROOT))

if "fastdeploy" not in sys.modules:

fastdeploy_pkg = types.ModuleType("fastdeploy")

fastdeploy_pkg.__path__ = [str(PROJECT_ROOT / "fastdeploy")]

fastdeploy_pkg.__spec__ = importlib.machinery.ModuleSpec("fastdeploy", loader=None, is_package=True)

sys.modules["fastdeploy"] = fastdeploy_pkg

if "paddle" not in sys.modules:

paddle_stub = types.ModuleType("paddle")

paddle_dist = types.ModuleType("paddle.distributed")

paddle_stub.distributed = paddle_dist

paddle_stub.Tensor = type("Tensor", (), {})

sys.modules["paddle"] = paddle_stub

sys.modules["paddle.distributed"] = paddle_dist

if "fastdeploy.utils" not in sys.modules:

class _Logger:

def info(self, *_, **__):

return None

def warning(self, *_, **__):

return None

def debug(self, *_, **__):

return None

def error(self, *_, **__):

return None

utils_stub = types.ModuleType("fastdeploy.utils")

utils_stub.get_logger = lambda *_, **__: _Logger()

utils_stub.data_processor_logger = _Logger()

utils_stub.scheduler_logger = _Logger()

utils_stub.llm_logger = _Logger()

sys.modules["fastdeploy.utils"] = utils_stub

if "fastdeploy.metrics" not in sys.modules:

metrics_pkg = types.ModuleType("fastdeploy.metrics")

metrics_pkg.__path__ = [str(PROJECT_ROOT / "fastdeploy" / "metrics")]

metrics_pkg.__spec__ = importlib.machinery.ModuleSpec("fastdeploy.metrics", loader=None, is_package=True)

sys.modules["fastdeploy.metrics"] = metrics_pkg

if "fastdeploy.metrics.metrics" not in sys.modules:

metrics_module = types.ModuleType("fastdeploy.metrics.metrics")

class _Counter:

def __init__(self):

self.value = 0

def inc(self, amount: int = 1):

self.value += amount

metrics_module.main_process_metrics = types.SimpleNamespace(send_cache_failed_num=_Counter())

sys.modules["fastdeploy.metrics.metrics"] = metrics_module

from fastdeploy.engine.request import (

CompletionOutput,

Request,

RequestMetrics,

RequestOutput,

)

from fastdeploy.engine.sampling_params import SamplingParams

from fastdeploy.splitwise import splitwise_connector

from fastdeploy.splitwise.splitwise_connector import SplitwiseConnector

# Use pytest fixture to stub required modules for test isolation

import pytest

@pytest.fixture(autouse=True)

def splitwise_stubs(monkeypatch):

import types

import importlib.machinery

from pathlib import Path

PROJECT_ROOT = Path(__file__).resolve().parents[2]

# fastdeploy package stub

fastdeploy_pkg = types.ModuleType("fastdeploy")

fastdeploy_pkg.__path__ = [str(PROJECT_ROOT / "fastdeploy")]

fastdeploy_pkg.__spec__ = importlib.machinery.ModuleSpec("fastdeploy", loader=None, is_package=True)

monkeypatch.setitem(sys.modules, "fastdeploy", fastdeploy_pkg)

# paddle stub

paddle_stub = types.ModuleType("paddle")

paddle_dist = types.ModuleType("paddle.distributed")

paddle_stub.distributed = paddle_dist

paddle_stub.Tensor = type("Tensor", (), {})

monkeypatch.setitem(sys.modules, "paddle", paddle_stub)

monkeypatch.setitem(sys.modules, "paddle.distributed", paddle_dist)

# fastdeploy.utils stub

class _Logger:

def info(self, *_, **__): return None

def warning(self, *_, **__): return None

def debug(self, *_, **__): return None

def error(self, *_, **__): return None

utils_stub = types.ModuleType("fastdeploy.utils")

utils_stub.get_logger = lambda *_, **__: _Logger()

utils_stub.data_processor_logger = _Logger()

utils_stub.scheduler_logger = _Logger()

utils_stub.llm_logger = _Logger()

monkeypatch.setitem(sys.modules, "fastdeploy.utils", utils_stub)

# fastdeploy.metrics package stub

metrics_pkg = types.ModuleType("fastdeploy.metrics")

metrics_pkg.__path__ = [str(PROJECT_ROOT / "fastdeploy" / "metrics")]

metrics_pkg.__spec__ = importlib.machinery.ModuleSpec("fastdeploy.metrics", loader=None, is_package=True)

monkeypatch.setitem(sys.modules, "fastdeploy.metrics", metrics_pkg)

# fastdeploy.metrics.metrics module stub

metrics_module = types.ModuleType("fastdeploy.metrics.metrics")

class _Counter:

def __init__(self): self.value = 0

def inc(self, amount: int = 1): self.value += amount

metrics_module.main_process_metrics = types.SimpleNamespace(send_cache_failed_num=_Counter())

monkeypatch.setitem(sys.modules, "fastdeploy.metrics.metrics", metrics_module)

# All imports of stubbed modules should be inside test functions below

Copilot · 2025-11-15T10:54:00Z

+def test_has_splitwise_tasks_detects_prefill_backlog():
+    cfg = make_cfg(innode_ports=[7001])
+    worker_queue = FakeEngineWorkerQueue()
+    connector = InspectableConnector(cfg, worker_queue, object())
+    connector.create_connection(7001)
+    queue = connector.connect_innode_instances[7001]
+    queue.available_prefill_instances.size = 1
+    assert connector.has_splitwise_tasks() is False
+    queue.available_prefill_instances.size = 0
+    assert connector.has_splitwise_tasks() is True
+
+
+def test_dispatch_innode_splitwise_tasks_promotes_decode_role():
+    cfg = make_cfg(innode_ports=[8002])
+    worker_queue = FakeEngineWorkerQueue()
+    connector = InspectableConnector(cfg, worker_queue, object())
+    connector.create_connection(8002)
+    queue = connector.connect_innode_instances[8002]
+    queue.prefill_ready = True
+    task = make_task("req-dispatch", role="prefill", protocol="ipc")
+    connector.dispatch_innode_splitwise_tasks([task], current_id=33)
+    assert queue.disaggregated_tasks[-1][0] == "prefill"
+    assert task.disaggregate_info["role"] == "decode"
+    assert task.disaggregate_info["cache_info"]["ipc"]["current_id"] == 33
+
+
+def test_send_splitwise_tasks_dispatches_when_innode_ports_available():
+    cfg = make_cfg(innode_ports=[8100])
+    worker_queue = FakeEngineWorkerQueue()
+    connector = InspectableConnector(cfg, worker_queue, object())
+    connector.create_connection(8100)
+    connector.connect_innode_instances[8100].prefill_ready = True
+    task = make_task("req-prefill", role="prefill", protocol="ipc")
+    connector.send_splitwise_tasks([task], current_id=44)
+    assert connector.connect_innode_instances[8100].disaggregated_tasks
+
+
+def test_send_splitwise_tasks_innode_rewrites_ports_for_decode_queue():
+    cfg = make_cfg()
+    worker_queue = FakeEngineWorkerQueue()
+    connector = InspectableConnector(cfg, worker_queue, object())
+    connector.create_connection(8123)
+    task = make_task("req-innode", role="decode", protocol="ipc")
+    snapshot_port = connector.send_splitwise_tasks_innode([task], 8123)
+    recorded = connector.connect_innode_instances[8123].disaggregated_tasks[-1]
+    assert snapshot_port == 8123
+    assert (
+        recorded[1][0].disaggregate_info["cache_info"]["ipc"]["port"]
+        == cfg.parallel_config.engine_worker_queue_port[0]
+    )
+    assert task.disaggregate_info["cache_info"]["ipc"]["port"] == 8123
+
+
+def test_send_splitwise_tasks_rdma_routes_and_resets_state():
+    cfg = make_cfg()
+    worker_queue = FakeEngineWorkerQueue()
+    connector = InspectableConnector(cfg, worker_queue, object())
+    task = make_task("req-remote", role="prefill", protocol="rdma")
+    connector.send_splitwise_tasks([task], current_id=55)
+    assert connector.sent_messages[-1][0] == "10.1.0.1:9010"
+    assert connector.sent_messages[-1][1] == "prefill"
+    assert connector.current_request_ids["req-remote"] == "init"
+    assert task.disaggregate_info["role"] == "prefill"
+
+
+def test_send_cache_infos_prefill_batches_into_worker_queue():
+    cfg = make_cfg()
+    worker_queue = FakeEngineWorkerQueue()
+    connector = InspectableConnector(cfg, worker_queue, object())
+    task = make_task("req-prefill", role="prefill", protocol="ipc")
+    was_decode = connector.send_cache_infos([task], current_id=11)
+    assert was_decode is False
+    assert worker_queue.cache_infos[-1][0]["request_id"] == "req-prefill"
+    assert worker_queue.cache_infos[-1][0]["current_id"] == 11
+
+
+def test_send_cache_infos_decode_rdma_triggers_remote_sync():
+    cfg = make_cfg()
+    worker_queue = FakeEngineWorkerQueue()
+    connector = InspectableConnector(cfg, worker_queue, object())
+    task = make_task("req-decode", role="decode", protocol="rdma")
+    result = connector.send_cache_infos([task], current_id=22)
+    assert result is True
+    assert connector.sent_messages[-1][1] == "cache_sync"
+    assert worker_queue.cache_infos == []
+
+
+def test_send_cache_infos_decode_ipc_forwards_to_local_worker():
+    cfg = make_cfg()
+    worker_queue = FakeEngineWorkerQueue()
+    connector = InspectableConnector(cfg, worker_queue, object())
+    connector.create_connection(9300)
+    task = make_task("req-local", role="decode", protocol="ipc")
+    task.disaggregate_info["cache_info"]["ipc"]["port"] = 9300
+    connector.send_cache_infos([task], current_id=7)
+    assert connector.connect_innode_instances[9300].cache_infos[-1][0]["transfer_protocol"] == "ipc"
+
+
+def test_send_cache_infos_rdma_with_error_message_forwards_reason():
+    cfg = make_cfg()
+    worker_queue = FakeEngineWorkerQueue()
+    connector = InspectableConnector(cfg, worker_queue, object())
+    task = make_task("req-err", role="decode", protocol="rdma")
+    task.error_msg = "remote boom"
+    connector.send_cache_infos([task], current_id=0)
+    assert connector.sent_messages[-1][1] == "cache_sync"
+    assert "error_msg" in connector.sent_messages[-1][2][0]
+
+
+def test_send_first_token_to_ipc_decode_queue():
+    cfg = make_cfg()
+    worker_queue = FakeEngineWorkerQueue()
+    connector = InspectableConnector(cfg, worker_queue, object())
+    connector.create_connection(9400)
+    msg = {"transfer_protocol": "ipc", "cache_info": {"ipc": {"port": 9400}}}
+    task = make_task("req-first", role="decode", protocol="ipc")
+    connector.send_first_token(msg, [task])
+    assert connector.connect_innode_instances[9400].disaggregated_tasks[-1][0] == "decode"
+
+
+def test_send_first_token_rdma_path(monkeypatch):
+    cfg = make_cfg()
+    worker_queue = FakeEngineWorkerQueue()
+    connector = InspectableConnector(cfg, worker_queue, object())
+    msg = {
+        "transfer_protocol": "rdma",
+        "cache_info": {"rdma": {"ip": "1.2.3.4", "port": 9123}},
+    }
+    task = make_task("req-first-rdma", role="decode", protocol="rdma")
+    connector.send_first_token(msg, task)
+    assert connector.sent_messages[-1][0] == "1.2.3.4:9123"
+    assert connector.sent_messages[-1][1] == "decode"
+
+
+def test_check_decode_allocated_reports_finish_and_error():
+    cfg = make_cfg()
+    worker_queue = FakeEngineWorkerQueue()
+    connector = InspectableConnector(cfg, worker_queue, object())
+    task = make_task("req-finish", role="prefill", protocol="rdma")
+    connector.current_request_ids["req-finish"] = "finished"
+    ok, msg = connector.check_decode_allocated(task)
+    assert ok and msg == ""
+    task2 = make_task("req-error", role="prefill", protocol="rdma")
+    connector.current_request_ids["req-error"] = "failed"
+    ok2, msg2 = connector.check_decode_allocated(task2)
+    assert ok2 is False and msg2 == "failed"
+
+
+def test_process_cache_sync_records_status_and_forwards(monkeypatch):
+    cfg = make_cfg()
+    worker_queue = FakeEngineWorkerQueue()
+    connector = InspectableConnector(cfg, worker_queue, object())
+    payload = [
+        {"request_id": "req-a", "error_msg": "boom"},
+        {"request_id": "req-b"},
+    ]
+    message = json.dumps({"type": "cache_sync", "payload": payload}).encode("utf-8")
+    connector._process_message(message)
+    assert connector.current_request_ids["req-a"] == "boom"
+    assert connector.current_request_ids["req-b"] == "finished"
+    assert worker_queue.cache_infos[-1] == payload
+
+
+def test_handle_prefill_and_decode_messages():
+    cfg = make_cfg()
+    worker_queue = FakeEngineWorkerQueue()
+    connector = InspectableConnector(cfg, worker_queue, object())
+    req = make_request_obj("req-handle")
+    connector._handle_prefill([req.to_dict()])
+    assert worker_queue.disaggregated_tasks[-1][0] == "decode"
+    completion = CompletionOutput(index=0, send_idx=0, token_ids=[])
+    metrics = RequestMetrics(arrival_time=0.0)
+    output = RequestOutput("req-out", outputs=completion, metrics=metrics)
+    connector._handle_decode([output.to_dict()])
+    assert worker_queue.disaggregated_tasks[-1][0] == "decode"
+
+
+def test_close_connection_removes_socket_reference():
+    cfg = make_cfg()
+    worker_queue = FakeEngineWorkerQueue()
+    connector = InspectableConnector(cfg, worker_queue, object())
+
+    class DummySocket:
+        def __init__(self):
+            self.closed = False
+
+        def close(self):
+            self.closed = True
+
+    dummy = DummySocket()
+    connector.push_sockets = {"test": dummy}
+    connector._close_connection("test")
+    assert dummy.closed is True
+    assert connector.push_sockets == {}
+
+
+def test_send_message_initializes_network_and_serializes(monkeypatch):
+    monkeypatch.setattr(splitwise_connector, "zmq", _make_stub_zmq())
+
+    class DummyExecutor:
+        def __init__(self, *_, **__):
+            self.calls = []
+
+        def submit(self, fn, *args, **kwargs):
+            self.calls.append((fn, args, kwargs))
+
+    monkeypatch.setattr(splitwise_connector, "ThreadPoolExecutor", DummyExecutor)
+
+    cfg = make_cfg(pd_comm_port=[9550], enable_expert_parallel=True, data_parallel_size=2, local_data_parallel_id=1)
+    worker_queue = FakeEngineWorkerQueue()
+    connector = SplitwiseConnector(cfg, worker_queue, object())
+    output = RequestOutput("req-zmq")
+    connector._send_message("127.0.0.1:9551", "decode", [output])
+    sock = connector.push_sockets["127.0.0.1:9551"]
+    assert json.loads(sock.sent[-1][1].decode("utf-8"))["type"] == "decode"
+
+
+def test_send_message_handles_failures_and_resets_socket(monkeypatch):
+    monkeypatch.setattr(splitwise_connector, "zmq", _make_stub_zmq())
+    monkeypatch.setattr(splitwise_connector, "ThreadPoolExecutor", lambda *_, **__: None)
+    cfg = make_cfg(pd_comm_port=[9660])
+    worker_queue = FakeEngineWorkerQueue()
+    connector = SplitwiseConnector(cfg, worker_queue, object())
+    failing_socket = _StubSocket(2)
+    failing_socket.should_fail = True
+    connector.push_sockets["node"] = failing_socket
+    splitwise_connector.main_process_metrics.send_cache_failed_num.value = 0
+    output = RequestOutput("req-fail")
+    connector._send_message("node", "decode", [output])
+    assert "node" not in connector.push_sockets
+    assert splitwise_connector.main_process_metrics.send_cache_failed_num.value == 1


Multiple port numbers are used throughout the tests (7001, 8002, 8100, 8123, 9300, 9400, etc.) without clear context about why specific values were chosen. Consider defining these as named constants at the module level (e.g., TEST_PORT_PREFILL = 7001) to improve readability and make it easier to understand the test scenarios.

…se_connector.py

…econnector Add innode splitwise test helpers

CSWYF3634076 · 2025-11-25T03:22:28Z

可以对ai Review的内容刷一遍，看是否有需要修改的部分，增加一些注释代码，部分类可以用Test或者Mock开头。
并参考这个PR完善对比信息 #5007

Refine Splitwise connector test stubs

codecov-commenter · 2025-11-25T18:18:29Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (develop@cb56d46). Learn more about missing BASE report.

Additional details and impacted files

@@            Coverage Diff             @@
##             develop    #5062   +/-   ##
==========================================
  Coverage           ?   60.32%           
==========================================
  Files              ?      317           
  Lines              ?    38778           
  Branches           ?     5844           
==========================================
  Hits               ?    23392           
  Misses             ?    13530           
  Partials           ?     1856

Flag	Coverage Δ
GPU	`60.32% <ø> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…se_connector.py

…/update-unit-tests-for-splitwise_connector-vxxscr

…wise_connector-vxxscr Add to_tensor stub for Splitwise connector tests

…se_connector.py

Update splitwise connector tests

xunyoyo · 2025-11-26T16:45:44Z

@CSWYF3634076 All passed，Review required.

CSWYF3634076 · 2025-11-27T06:23:33Z

0.2⭐️

YuanRisheng · 2025-11-28T03:54:13Z

单测需要进一步规范及模块负责人参与review，建议revert后重新提交

This reverts commit 373b5c3.

* Add tests for SplitwiseConnector functionality This commit introduces a comprehensive test suite for the SplitwiseConnector class, implementing various tests to ensure the correct functionality of task dispatching, message sending, and connection handling. The tests cover scenarios for both prefill and decode roles, including checks for task promotion, message serialization, and error handling. * Add innode splitwise test helpers * Refine Splitwise connector test stubs * Add to_tensor stub for splitwise tests * Update splitwise connector tests

…#5062)" (PaddlePaddle#5291) This reverts commit 373b5c3.

* Add tests for SplitwiseConnector functionality This commit introduces a comprehensive test suite for the SplitwiseConnector class, implementing various tests to ensure the correct functionality of task dispatching, message sending, and connection handling. The tests cover scenarios for both prefill and decode roles, including checks for task promotion, message serialization, and error handling. * Add innode splitwise test helpers * Refine Splitwise connector test stubs * Add to_tensor stub for splitwise tests * Update splitwise connector tests

…#5062)" (PaddlePaddle#5291) This reverts commit 93f50c5.

Copilot AI review requested due to automatic review settings November 15, 2025 10:48

paddle-bot Bot added the contributor External developers label Nov 15, 2025

Copilot started reviewing on behalf of xunyoyo November 15, 2025 10:49

View session

Copilot finished reviewing on behalf of xunyoyo November 15, 2025 10:51

Copilot AI reviewed Nov 15, 2025

View reviewed changes

luotao1 mentioned this pull request Nov 17, 2025

【Hackathon 9th】开源贡献个人挑战赛冲刺赛 PaddlePaddle/Paddle#76333

Closed

luotao1 added the PaddlePaddle Hackathon label Nov 17, 2025

luotao1 assigned luotao1 and CSWYF3634076 Nov 17, 2025

xunyoyo added 3 commits November 17, 2025 20:50

Merge branch 'PaddlePaddle:develop' into fastdeploy/splitwise/splitwi…

c708e85

…se_connector.py

Add innode splitwise test helpers

294d5e3

Merge pull request #16 from xunyoyo/codex/add-unit-tests-for-splitwis…

b844ac2

…econnector Add innode splitwise test helpers

xunyoyo added 2 commits November 26, 2025 01:08

Refine Splitwise connector test stubs

3045066

Merge pull request #26

e6e991e

Refine Splitwise connector test stubs

xunyoyo added 7 commits November 26, 2025 14:34

Merge branch 'PaddlePaddle:develop' into fastdeploy/splitwise/splitwi…

b6db435

…se_connector.py

Add to_tensor stub for splitwise tests

7a9a8e1

Merge branch 'fastdeploy/splitwise/splitwise_connector.py' into codex…

07059e3

…/update-unit-tests-for-splitwise_connector-vxxscr

Merge pull request #31 from xunyoyo/codex/update-unit-tests-for-split…

0ee1b64

…wise_connector-vxxscr Add to_tensor stub for Splitwise connector tests

Merge branch 'PaddlePaddle:develop' into fastdeploy/splitwise/splitwi…

c093927

…se_connector.py

Update splitwise connector tests

83d147d

Merge pull request #32

0196374

Update splitwise connector tests

xunyoyo closed this Nov 26, 2025

xunyoyo deleted the fastdeploy/splitwise/splitwise_connector.py branch November 26, 2025 15:53

xunyoyo restored the fastdeploy/splitwise/splitwise_connector.py branch November 26, 2025 15:55

xunyoyo reopened this Nov 26, 2025

CSWYF3634076 approved these changes Nov 27, 2025

View reviewed changes

CSWYF3634076 merged commit 373b5c3 into PaddlePaddle:develop Nov 27, 2025
20 of 25 checks passed

luotao1 changed the title ~~[CI] 【Hackathon 9th Sprint No.41】NO.41 功能模块单测补充~~ [CI] 【Hackathon 9th Sprint No.41】NO.41 功能模块单测补充 -part Nov 28, 2025

YuanRisheng added a commit that referenced this pull request Nov 28, 2025

Revert "[CI] 【Hackathon 9th Sprint No.41】NO.41 功能模块单测补充 (#5062)"

130143f

This reverts commit 373b5c3.

YuanRisheng mentioned this pull request Nov 28, 2025

Revert "[CI] 【Hackathon 9th Sprint No.41】NO.41 功能模块单测补充 -part" #5291

Merged

CSWYF3634076 pushed a commit that referenced this pull request Dec 2, 2025

Revert "[CI] 【Hackathon 9th Sprint No.41】NO.41 功能模块单测补充 (#5062)" (#5291)

ded7765

This reverts commit 373b5c3.

chang-wenbin pushed a commit to chang-wenbin/FastDeploy that referenced this pull request Mar 2, 2026

Revert "[CI] 【Hackathon 9th Sprint No.41】NO.41 功能模块单测补充 (PaddlePaddle…

35ebad1

…#5062)" (PaddlePaddle#5291) This reverts commit 373b5c3.

xiaoguoguo626807 pushed a commit to xiaoguoguo626807/FastDeploy that referenced this pull request May 7, 2026

Revert "[CI] 【Hackathon 9th Sprint No.41】NO.41 功能模块单测补充 (PaddlePaddle…

0227778

…#5062)" (PaddlePaddle#5291) This reverts commit 93f50c5.

	assert connector.has_splitwise_tasks() is True
	assert connector.has_splitwise_tasks()

Conversation

xunyoyo commented Nov 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Modifications

Usage or Command

Accuracy Tests

Checklist

Uh oh!

paddle-bot Bot commented Nov 15, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Key Changes

Uh oh!

Copilot AI Nov 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 15, 2025

Choose a reason for hiding this comment

Uh oh!

CSWYF3634076 commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

xunyoyo commented Nov 26, 2025

Uh oh!

CSWYF3634076 commented Nov 27, 2025

Uh oh!

Uh oh!

YuanRisheng commented Nov 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

xunyoyo commented Nov 15, 2025 •

edited

Loading

CSWYF3634076 commented Nov 25, 2025 •

edited

Loading

codecov-commenter commented Nov 25, 2025 •

edited

Loading