[CI] 【Hackathon 9th Sprint No.38】NO.38 功能模块单测补充 by xunyoyo · Pull Request #5060 · PaddlePaddle/FastDeploy

xunyoyo · 2025-11-15T10:40:38Z

This file contains tests for the global scheduler, including request handling, load accounting, and response management.

Motivation

NO.38 功能模块 fastdeploy/scheduler/global_scheduler.py 单测补充

Modifications

new dir and add tests/scheduler/test_global_scheduler.py

Usage or Command

tests/scheduler/test_global_scheduler.py:

python -m coverage run -m unittest tests.scheduler.test_global_scheduler \
&& python -m coverage report -m --include='fastdeploy/scheduler/global_scheduler.py'

Accuracy Tests

原来的覆盖：

tests/scheduler/test_global_scheduler.py:

覆盖 ++270 行

Checklist

Add at least a tag in the PR title.
- Tag list: [[FDConfig],[APIServer],[Engine], [Scheduler], [PD Disaggregation], [Executor], [Graph Optimization], [Speculative Decoding], [RL], [Models], [Quantization], [Loader], [OP], [KVCache], [DataProcessor], [BugFix], [Docs], [CI], [Optimization], [Feature], [Benchmark], [Others], [XPU], [HPU], [GCU], [DCU], [Iluvatar], [Metax]]
- You can add new tags based on the PR content, but the semantics must be clear.
Format your code, run pre-commit before commit.
Add unit tests. Please write the reason in this PR if no unit tests.
Provide accuracy results.
If the current PR is submitting to the release branch, make sure the PR has been submitted to the develop branch, then cherry-pick it to the release branch with the [Cherry-Pick] PR tag.

This file contains tests for the global scheduler, including request handling, load accounting, and response management.

paddle-bot · 2025-11-15T10:40:44Z

Thanks for your contribution!

Copilot

Pull Request Overview

This PR adds comprehensive unit tests for the global scheduler module (fastdeploy/scheduler/global_scheduler.py) as part of Hackathon 9th Sprint No.38. The tests use pytest with custom fixtures and mocks to achieve 83% code coverage.

Key Changes

Implements fake Redis and worker implementations for isolated testing
Tests request handling, load balancing, request stealing, and response routing
Adds tests for scheduler configuration and reset functionality
Includes helper function tests for block calculation and request/response marking

Copilot · 2025-11-15T10:44:37Z

+
+def test_get_requests_requeues_when_chunked_limits_hit(scheduler_fixture):
+    scheduler, fake_redis = scheduler_fixture
+    envs.FD_ENABLE_MAX_PREFILL = 0


Directly modifying envs.FD_ENABLE_MAX_PREFILL without restoring it can lead to test isolation issues. Consider using monkeypatch.setattr(envs, "FD_ENABLE_MAX_PREFILL", 0) to ensure the value is automatically restored after the test completes.

Copilot · 2025-11-15T10:44:37Z

+
+def test_get_requests_blocking_pop_returns_when_idle(scheduler_fixture):
+    scheduler, fake_redis = scheduler_fixture
+    envs.FD_ENABLE_MAX_PREFILL = 0


Directly modifying envs.FD_ENABLE_MAX_PREFILL without restoring it can lead to test isolation issues. Consider using monkeypatch.setattr(envs, "FD_ENABLE_MAX_PREFILL", 0) to ensure the value is automatically restored after the test completes.

Copilot · 2025-11-15T10:44:38Z

+    python -m coverage run -m pytest tests/scheduler/test_global_scheduler.py \
+        && python -m coverage report -m --include='fastdeploy/scheduler/global_scheduler.py'


The command in the docstring uses pytest (python -m coverage run -m pytest), but the PR description specifies unittest (python -m unittest tests.scheduler.test_global_scheduler). These should be consistent. Since the tests use pytest fixtures, the docstring appears correct, but this inconsistency with the PR description may confuse users.

Copilot · 2025-11-15T10:44:38Z

@@ -0,0 +1,431 @@
+"""Tests for the global scheduler.


Missing the Apache 2.0 license header that is present in all other test files in this repository. The copyright header should be added at the top of the file following the project's convention:

""" # Copyright (c) 2025 PaddlePaddle Authors. All Rights Reserved. # # Licensed under the Apache License, Version 2.0 (the "License" # you may not use this file except in compliance with the License. # You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law or agreed to in writing, software # distributed under the License is distributed on an "AS IS" BASIS, # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # See the License for the specific language governing permissions and # limitations under the License. """

Enhance global scheduler test coverage

Removed unnecessary comments and coverage instructions.

codecov-commenter · 2025-12-15T13:17:57Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (develop@d739af5). Learn more about missing BASE report.

Additional details and impacted files

@@            Coverage Diff             @@
##             develop    #5060   +/-   ##
==========================================
  Coverage           ?   64.43%           
==========================================
  Files              ?      329           
  Lines              ?    41756           
  Branches           ?     6388           
==========================================
  Hits               ?    26906           
  Misses             ?    12798           
  Partials           ?     2052

Flag	Coverage Δ
GPU	`64.43% <ø> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

lddfym · 2025-12-18T09:11:44Z

1.可以参考下 copilot 给出的建议
2.需要增加一些注释

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Updated comments and docstrings in Chinese to enhance clarity for native speakers.

Replaced direct assignment with monkeypatching for FD_ENABLE_MAX_PREFILL in test cases.

Fix function definitions and update test cases for scheduler.

Fix typos in global scheduler tests

EmmonsCurse · 2025-12-18T09:39:16Z

@xunyoyo Please confirm your changes carefully and avoid triggering the job repeatedly. Otherwise, trigger permissions may be revoked.

xunyoyo · 2025-12-18T14:14:09Z

@lddfym 麻烦review~

lddfym · 2025-12-19T02:56:18Z

代码中的注释请改用英文吧，和整体代码风格保持一致

Updated comments and docstrings in test_global_scheduler.py from Chinese to English for better clarity and consistency.

xunyoyo · 2025-12-19T05:32:22Z

@lddfym 已修改

lddfym · 2025-12-19T06:37:19Z

LGTM

CSWYF3634076 · 2025-12-19T08:28:44Z

0.3⭐️
@luotao1

* Add tests for global scheduler functionality This file contains tests for the global scheduler, including request handling, load accounting, and response management. * Enhance global scheduler unit tests * Clean up comments in test_global_scheduler.py Removed unnecessary comments and coverage instructions. * Update tests/scheduler/test_global_scheduler.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update tests/scheduler/test_global_scheduler.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update tests/scheduler/test_global_scheduler.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update tests/scheduler/test_global_scheduler.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Translate comments and docstrings to Chinese Updated comments and docstrings in Chinese to enhance clarity for native speakers. * Use monkeypatch for FD_ENABLE_MAX_PREFILL in tests Replaced direct assignment with monkeypatching for FD_ENABLE_MAX_PREFILL in test cases. * Correct test function definitions in test_global_scheduler Fix function definitions and update test cases for scheduler. * Fix typos in global scheduler tests * Translate comments to English in test_global_scheduler.py Updated comments and docstrings in test_global_scheduler.py from Chinese to English for better clarity and consistency. --------- Co-authored-by: CSWYF3634076 <wangyafeng@baidu.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Jiaxin Sui <95567040+plusNew001@users.noreply.github.com>

Add tests for global scheduler functionality

29bf28a

This file contains tests for the global scheduler, including request handling, load accounting, and response management.

Copilot AI review requested due to automatic review settings November 15, 2025 10:40

paddle-bot Bot added the contributor External developers label Nov 15, 2025

Copilot started reviewing on behalf of xunyoyo November 15, 2025 10:41

View session

Copilot finished reviewing on behalf of xunyoyo November 15, 2025 10:43

Copilot AI reviewed Nov 15, 2025

View reviewed changes

luotao1 mentioned this pull request Nov 17, 2025

【Hackathon 9th】开源贡献个人挑战赛冲刺赛 PaddlePaddle/Paddle#76333

Closed

luotao1 added the PaddlePaddle Hackathon label Nov 17, 2025

luotao1 assigned luotao1 and CSWYF3634076 Nov 17, 2025

CSWYF3634076 and others added 6 commits December 12, 2025 11:33

Merge branch 'develop' into fastdeploy/scheduler/global_scheduler.py

973200c

Enhance global scheduler unit tests

717c004

Merge pull request #46

aab7d1b

Enhance global scheduler test coverage

Clean up comments in test_global_scheduler.py

d5d7eba

Removed unnecessary comments and coverage instructions.

Merge branch 'develop' into fastdeploy/scheduler/global_scheduler.py

894e3c4

Merge branch 'develop' into fastdeploy/scheduler/global_scheduler.py

01bbda9

CSWYF3634076 requested a review from lddfym December 17, 2025 08:40

CSWYF3634076 assigned lddfym Dec 17, 2025

xunyoyo and others added 9 commits December 18, 2025 17:14

Update tests/scheduler/test_global_scheduler.py

906d8b9

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update tests/scheduler/test_global_scheduler.py

87e4906

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update tests/scheduler/test_global_scheduler.py

e927073

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update tests/scheduler/test_global_scheduler.py

9ab9741

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Translate comments and docstrings to Chinese

88f6e05

Updated comments and docstrings in Chinese to enhance clarity for native speakers.

Use monkeypatch for FD_ENABLE_MAX_PREFILL in tests

ebb5e77

Replaced direct assignment with monkeypatching for FD_ENABLE_MAX_PREFILL in test cases.

Correct test function definitions in test_global_scheduler

f1da209

Fix function definitions and update test cases for scheduler.

Fix typos in global scheduler tests

f81c0e0

Merge pull request #54

d8db5f7

Fix typos in global scheduler tests

Merge branch 'develop' into fastdeploy/scheduler/global_scheduler.py

5731c3d

Translate comments to English in test_global_scheduler.py

60748ff

Updated comments and docstrings in test_global_scheduler.py from Chinese to English for better clarity and consistency.

CSWYF3634076 approved these changes Dec 19, 2025

View reviewed changes

CSWYF3634076 merged commit 669dfe8 into PaddlePaddle:develop Dec 19, 2025
16 of 19 checks passed

		python -m coverage run -m pytest tests/scheduler/test_global_scheduler.py \
		&& python -m coverage report -m --include='fastdeploy/scheduler/global_scheduler.py'

Conversation

xunyoyo commented Nov 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Modifications

Usage or Command

Accuracy Tests

Checklist

Uh oh!

paddle-bot Bot commented Nov 15, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Key Changes

Uh oh!

Copilot AI Nov 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 15, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Nov 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 15, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov-commenter commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

lddfym commented Dec 18, 2025

Uh oh!

EmmonsCurse commented Dec 18, 2025

Uh oh!

xunyoyo commented Dec 18, 2025

Uh oh!

lddfym commented Dec 19, 2025

Uh oh!

xunyoyo commented Dec 19, 2025

Uh oh!

lddfym commented Dec 19, 2025

Uh oh!

Uh oh!

CSWYF3634076 commented Dec 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

xunyoyo commented Nov 15, 2025 •

edited

Loading

codecov-commenter commented Dec 15, 2025 •

edited

Loading