Skip to content

[CLI]Update parameters in bench latecy cli tool and fix collect-env cli tool #4558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jiang-Jia-Jun merged 2 commits into from
Oct 24, 2025
Merged

[CLI]Update parameters in bench latecy cli tool and fix collect-env cli tool #4558

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c57f25
add collect-env
qwes5s5 Oct 23, 2025
9ce9dca
del files
qwes5s5 Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fastdeploy/benchmarks/latency.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ def main(args: argparse.Namespace):
# NOTE(woosuk): If the request cannot be processed in a single batch,
# the engine will automatically process the request in multiple batches.
llm = LLM(**dataclasses.asdict(engine_args))
assert llm.llm_engine.cfg.max_model_len >= (args.input_len + args.output_len), (
assert llm.llm_engine.cfg.model_config.max_model_len >= (args.input_len + args.output_len), (
"Please ensure that max_model_len is greater than" " the sum of input_len and output_len."
)

Expand Down
2 changes: 2 additions & 0 deletions fastdeploy/entrypoints/cli/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@

def main():
import fastdeploy.entrypoints.cli.benchmark.main
import fastdeploy.entrypoints.cli.collect_env
import fastdeploy.entrypoints.cli.openai
import fastdeploy.entrypoints.cli.run_batch
import fastdeploy.entrypoints.cli.serve
Expand All @@ -34,6 +35,7 @@ def main():
fastdeploy.entrypoints.cli.openai,
fastdeploy.entrypoints.cli.benchmark.main,
fastdeploy.entrypoints.cli.serve,
fastdeploy.entrypoints.cli.collect_env,
]

parser = FlexibleArgumentParser(description="FastDeploy CLI")
Expand Down
4 changes: 2 additions & 2 deletions tests/benchmarks/test_latency_benchmarks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def test_main(self, mock_tqdm, mock_randint, mock_llm):
mock_llm_instance = MagicMock()
mock_llm.return_value = mock_llm_instance
mock_cfg = MagicMock()
mock_cfg.max_model_len = 2048
mock_cfg.model_config.max_model_len = 2048
mock_llm_instance.llm_engine.cfg = mock_cfg

mock_randint.return_value = np.zeros((8, 32))
Expand Down Expand Up @@ -74,7 +74,7 @@ def test_main_profile_error(self, mock_exit, mock_llm):
mock_llm_instance = MagicMock()
mock_llm.return_value = mock_llm_instance
mock_cfg = MagicMock()
mock_cfg.max_model_len = 2048
mock_cfg.model_config.max_model_len = 2048
mock_llm_instance.llm_engine.cfg = mock_cfg

# Build args using parser
Expand Down
Loading