【Hackathon 9th No.78】add test_chat.py #3958
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
|
/re-run all-failed |
1 similar comment
|
/re-run all-failed |
ltd0924
reviewed
Sep 11, 2025
tests/entrypoints/test_chat.py
Outdated
| "Hello, my name is", | ||
| "The capital of China is", | ||
| "The future of AI is", | ||
| "人工智能是", |
| outputs = self.llm.chat(messages=prompts, sampling_params=None) | ||
| self.assertEqual(len(self.PROMPTS), len(outputs)) | ||
|
|
||
|
|
There was a problem hiding this comment.
如果测试内容与generate 完全一致，建议合并不需要再增加chat的单独测试，单测需要体现chat 接口与generate接口的不同
There was a problem hiding this comment.
chat 和 generate参数一样，实现不一样，generate是使用的prompt参数调用_add_request接口，chat是使用的messages封装后调用_add_request接口
There was a problem hiding this comment.
chat 是一个对话的形式，generate 是续写，所以希望你进行测试数据的替换。
chat 与 generate 底层实现确实不同，但是在你的单测中并没有体现，如果需要端到端测试，generation 可以 chat 合并，使用同一个llm
There was a problem hiding this comment.
已修改test_chat单测，chat 和 generation相同参数部分合并测试
ltd0924
approved these changes
Sep 12, 2025
|
@luotao1 CI已完成 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fastdeploy/entrypoints 单测补充
已有 test_generation.py，增加 add test_chat.py
修改 fastdeploy/entrypoints/llm.py，如果消息包含prompt_token_ids字段，不再增加一层列表
输入会被修改，需要使用 copy.copy 复制