-
Notifications
You must be signed in to change notification settings - Fork 634
【Hackathon 9th No.25】add test_fused_get_rotary_embedding #3892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
你好,只比较shape是否符合预期,很难监控到可能出现的精度问题;按照自定义算子的检查标准,最好通过numpy/paddle的已有操作得到一个基础版本实现作为基准,并使用同样的输入比较两个版本的输出是否一致
可以参考下面单测的形式(不一定和本算子当前的功能行为一致,仅供参考)
https://github.com/PaddlePaddle/Paddle/blob/1d9df745e8a9a58c54e770b2b97dff89153017e4/test/legacy_test/test_fused_rotary_position_embedding.py#L117
Thx, Done.
@zoooo0820 pls review~ |
看起来没问题,我跟进下CI报错 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
02920fc
抱歉之前的代码不小心把开源软件的版权和许可声明的注释删掉了,刚刚发现,补充了一下。 |
test_fused_get_rotary_embedding